delta/node-new.git/src/node.cc, branch ofrobots-patch-1

src: trace_event: secondary storage for metadata

2018-10-12T21:12:31+00:00

Metadata trace-events should be held in secondary storage so that they
can be periodically reemitted. This change establishes the secondary
storage and ensures that events are reemitted on each flush.

PR-URL: https://github.com/nodejs/node/pull/20900
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: improve SSL version extraction logic

2018-10-12T04:25:52+00:00

The openssl version as defined in ssl libraries is complex.
The current logic to extract the major.minor.patch format
uses C semantics to loop through the text and search for
specific patterns. Use C++ string to tidy it up.

PR-URL: https://github.com/nodejs/node/pull/23050
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Refael Ackermann 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson

src: replace NO_RETURN with [[noreturn]]

2018-10-11T23:53:20+00:00

PR-URL: https://github.com/nodejs/node/pull/23337
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis

trace_events: destroy platform before tracing

2018-10-06T13:05:17+00:00

For safer shutdown, we should destroy the platform – and background
threads - before the tracing infrastructure is destroyed. This change
fixes the relative order of NodePlatform disposition and the tracing
agent shutting down. This matches the nesting order for startup.

Make the tracing agent own the tracing controller instead of platform
to match the above.

Fixes: https://github.com/nodejs/node/issues/22865

PR-URL: https://github.com/nodejs/node/pull/22938
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

src: remove public API for option variables

2018-10-03T21:08:06+00:00

PR-URL: https://github.com/nodejs/node/pull/23069
Reviewed-By: Gus Caplan 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Shingo Inoue 
Reviewed-By: Refael Ackermann

src: remove unused using declarations

2018-10-01T10:49:56+00:00

PR-URL: https://github.com/nodejs/node/pull/23120
Reviewed-By: Anna Henningsen 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

src: remove unused locale.h

2018-10-01T10:49:56+00:00

This commit removes the locale.h header as it does not look like it is
used.

PR-URL: https://github.com/nodejs/node/pull/23120
Reviewed-By: Anna Henningsen 
Reviewed-By: Michael Dawson 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

src: refactor win32 `DebugProcess()` to use RAII cleanup

2018-09-23T20:47:47+00:00

Prefer more idiomatic C++ cleanup code over `goto`.

PR-URL: https://github.com/nodejs/node/pull/22981
Reviewed-By: Tobias Nießen 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Bartosz Sosnowski 
Reviewed-By: Denys Otrishko 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: add CheckOptions to Options classes

2018-09-22T10:00:28+00:00

This commit adds a CheckOptions function that the options classes can
optionally implement to check that options specified are correct
(dependencies between options are met or options that are mutually
exclusive).

In the process of doing this the error pointer passed to Parse was
changed to be of type vector so that potentially multiple options check
failures can be reported.

PR-URL: https://github.com/nodejs/node/pull/22943
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

src: initialize pid variable before goto

2018-09-20T19:10:58+00:00

This fixes an error when compiling with clang-cl on Windows:

```
src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
    goto out;
    ^
src/node.cc(2441,9):  note: jump bypasses variable initialization
  DWORD pid = args[0].As()->Value();
        ^
```

PR-URL: https://github.com/nodejs/node/pull/22961
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung