delta/node-new.git/src/module_wrap.h, branch pull-request-doc-updates

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

vm: add dynamic import support

2018-10-06T22:33:25+00:00

PR-URL: https://github.com/nodejs/node/pull/22381
Reviewed-By: James M Snell 
Reviewed-By: Guy Bedford 
Reviewed-By: Tiancheng "Timothy" Gu

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: add proper MemoryInfoName to wrappers

2018-07-27T07:51:19+00:00

- Use camel case names for memory retainers inherited from AsyncWrap
  instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
  as nodes with class names as node names. Previously some nodes are
  named with reference names, which are supposed to be edge names
  instead.

PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: enable more detailed memory tracking

2018-07-13T17:53:15+00:00

This will enable more detailed heap snapshots based on
a newer V8 API.

This commit itself is not tied to that API and could
be backported.

PR-URL: https://github.com/nodejs/node/pull/21742
Reviewed-By: James M Snell

src: prevent persistent handle resource leaks

2018-02-21T14:24:18+00:00

Replace v8::Persistent with node::Persistent, a specialization that
resets the persistent handle on destruction.  Prevents accidental
resource leaks when forgetting to call .Reset() manually.

I'm fairly confident this commit fixes a number of resource leaks that
have gone undiagnosed so far.

PR-URL: https://github.com/nodejs/node/pull/18656
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

module: support main w/o extension, pjson cache

2018-02-14T14:35:12+00:00

This adds support for ensuring that the top-level main into Node is
supported loading when it has no extension for backwards-compat with
NodeJS bin workflows.

In addition package.json caching is implemented in the module lookup
process.

PR-URL: https://github.com/nodejs/node/pull/18728
Reviewed-By: Benjamin Gruenbaum

src,lib: implement import.meta

2018-02-01T12:46:56+00:00

Implement the C++ callback that is required to configure the
`import.meta` object and add one property:
- url: absolute URL of the module

PR-URL: https://github.com/nodejs/node/pull/18368
Reviewed-By: Guy Bedford 
Reviewed-By: Bradley Farias 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu

vm: add modules

2018-01-31T01:00:57+00:00

Adds vm.Module, which wraps around ModuleWrap to provide an interface
for developers to work with modules in a more reflective manner.

Co-authored-by: Timothy Gu 
PR-URL: https://github.com/nodejs/node/pull/17560
Reviewed-By: Michaël Zasso 
Reviewed-By: Tiancheng "Timothy" Gu

module: Set dynamic import callback

2017-11-29T22:16:43+00:00

This is an initial implementation to support dynamic import in
both scripts and modules. It's off by default since support for
dynamic import is still flagged in V8. Without setting the V8 flag,
this code won't be executed.

This initial version does not support importing into vm contexts.

PR-URL: https://github.com/nodejs/node/pull/15713
Reviewed-By: Timothy Gu 
Reviewed-By: Bradley Farias