delta/node-new.git/src/module_wrap.cc, branch Ninja.py-StringIO github.com: nodejs/node.git module: avoid passing unnecessary loop reference 2019-08-23T06:03:16+00:00 Saúl Ibarra Corretgé s@saghul.net 2019-08-22T21:45:49+00:00 2fc87685d90ea9a8ad21d2f4515eaf329d71b3f1 It's a sync request, which doesn't require the loop parameter to be set. PR-URL: https://github.com/nodejs/node/pull/29275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> 
It's a sync request, which doesn't require the loop parameter to be set.

PR-URL: https://github.com/nodejs/node/pull/29275
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
module: pkg exports validations and fallbacks 2019-08-12T10:24:28+00:00 Guy Bedford guybedford@gmail.com 2019-08-02T05:30:32+00:00 2103ae483547831281e1e3882029e37d445689a7 PR-URL: https://github.com/nodejs/node/pull/28949 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/28949
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
module: refine package name validation 2019-08-08T02:56:11+00:00 Guy Bedford guybedford@gmail.com 2019-08-05T06:24:54+00:00 0e03c449e35e4951e9e9c962ff279ec271e62010 PR-URL: https://github.com/nodejs/node/pull/28965 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/28965
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
module: exports error as MODULE_NOT_FOUND 2019-08-02T03:36:27+00:00 Guy Bedford guybedford@gmail.com 2019-07-31T01:41:58+00:00 452b393c1fc993c50acd447eb84eeea529b89111 PR-URL: https://github.com/nodejs/node/pull/28905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/28905
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
module: unify package exports test for CJS and ESM 2019-07-31T20:33:46+00:00 Jan Krems jan.krems@gmail.com 2019-07-24T04:25:24+00:00 61f3a5c60ad78506e9e0caae061a04ccab878ca1 Refs: https://github.com/nodejs/modules/issues/358 PR-URL: https://github.com/nodejs/node/pull/28831 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> 
Refs: https://github.com/nodejs/modules/issues/358

PR-URL: https://github.com/nodejs/node/pull/28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
module: implement "exports" proposal for CommonJS 2019-07-23T23:11:20+00:00 Jan Krems jan.krems@gmail.com 2019-07-19T04:52:55+00:00 dcb692918348986945cbd4fbce8158b2b97a8418 Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36 Refs: https://github.com/nodejs/node/pull/28568 PR-URL: https://github.com/nodejs/node/pull/28759 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> 
Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36
Refs: https://github.com/nodejs/node/pull/28568

PR-URL: https://github.com/nodejs/node/pull/28759
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
src: make `CompiledFnEntry` a `BaseObject` 2019-07-22T18:55:25+00:00 Anna Henningsen anna@addaleax.net 2019-07-20T17:35:24+00:00 89e4b36e62978f54b2e33b4bce8197072dbe8af1 In particular: - Move the class definition to the relevant header file, i.e. `node_contextify.h`. - Make sure that class instances are destroyed on `Environment` teardown. - Make instances of the key object traceable in heap dumps. This is particularly relevant here because our C++ script → map key mapping could introduce memory leaks when the import function metadata refers back to the script in some way. Refs: https://github.com/nodejs/node/pull/28671 PR-URL: https://github.com/nodejs/node/pull/28782 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> 
In particular:

- Move the class definition to the relevant header file,
  i.e. `node_contextify.h`.
- Make sure that class instances are destroyed on
  `Environment` teardown.
- Make instances of the key object traceable in heap dumps. This is
  particularly relevant here because our C++ script → map key mapping
  could introduce memory leaks when the import function metadata refers
  back to the script in some way.

Refs: https://github.com/nodejs/node/pull/28671

PR-URL: https://github.com/nodejs/node/pull/28782
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
src: silence compiler warning 2019-07-22T14:55:11+00:00 cjihrig cjihrig@gmail.com 2019-07-19T12:59:35+00:00 65c2b2ce392b5304cb7d5c3d10de5db1b7b31dbe This commit fixes the following warning: warning: missing field 'exports' initializer PR-URL: https://github.com/nodejs/node/pull/28764 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> 
This commit fixes the following warning:

warning: missing field 'exports' initializer

PR-URL: https://github.com/nodejs/node/pull/28764
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
vm: fix gc bug with modules and compiled functions 2019-07-19T21:45:46+00:00 Gus Caplan me@gus.host 2019-07-19T14:30:09+00:00 68c83f962e002a47f61648c5aa2adb41dbe6a358 PR-URL: https://github.com/nodejs/node/pull/28671 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Guy Bedford <guybedford@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/28671
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
esm: implement "pkg-exports" proposal 2019-07-18T21:54:16+00:00 Guy Bedford guybedford@gmail.com 2019-01-16T01:11:10+00:00 6df7b6a4f9cb64d298e7fd0691c4d09679872922 Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36 PR-URL: https://github.com/nodejs/node/pull/28568 Reviewed-By: Anna Henningsen <anna@addaleax.net> 
Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36

PR-URL: https://github.com/nodejs/node/pull/28568
Reviewed-By: Anna Henningsen <anna@addaleax.net>