delta/node-new.git/src/js_native_api_v8.cc, branch Ninja.py-StringIO

n-api: add APIs for per-instance state management

2019-07-25T23:53:07+00:00

Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
allow native addons to store their data on and retrieve their data from
`napi_env`. `napi_set_instance_data()` accepts a finalizer which is
called when the `node::Environment()` is destroyed.

This entails rendering the `napi_env` local to each add-on.

Fixes: https://github.com/nodejs/abi-stable-node/issues/378
PR-URL: https://github.com/nodejs/node/pull/28682
Reviewed-By: Ben Noordhuis 
Reviewed-By: Michael Dawson

n-api: correct bug in napi_get_last_error

2019-07-17T19:11:36+00:00

napi_get_last_error returns incorrect napi_status.

PR-URL: https://github.com/nodejs/node/pull/28702
Reviewed-By: James M Snell 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson

n-api: add error message for date expected

2019-06-23T18:26:00+00:00

PR-URL: https://github.com/nodejs/node/pull/28303
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson

n-api: define ECMAScript-compliant accessors on napi_define_class

2019-06-17T10:07:08+00:00

PR-URL: https://github.com/nodejs/node/pull/27851
Fixes: https://github.com/nodejs/node/issues/26551
Fixes: https://github.com/nodejs/node-addon-api/issues/485
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Michael Dawson

n-api: define ECMAScript-compliant accessors on napi_define_properties

2019-06-17T10:06:06+00:00

PR-URL: https://github.com/nodejs/node/pull/27851
Fixes: https://github.com/nodejs/node/issues/26551
Fixes: https://github.com/nodejs/node-addon-api/issues/485
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Michael Dawson

src: add napi_define_class() null checks

2019-06-08T04:33:00+00:00

napi_define_class is tested by passing NULL to all parameters that are
pointers, one at a time. Moreover, two bugs were corrected. One was
utf8name and the second was the property descriptor pointer. These
pointers were assumed to be non-NULL and now we have NULL checks.

PR-URL: https://github.com/nodejs/node/pull/27945
Reviewed-By: Gabriel Schulhof

n-api: DRY napi_coerce_to_x() API methods

2019-05-24T03:19:34+00:00

PR-URL: https://github.com/nodejs/node/pull/27796
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell

src: remove env-inl.h from header files

2019-05-23T15:51:41+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

n-api: make napi_get_property_names return strings

2019-05-06T03:12:27+00:00

The documentation says that this method returns an array of strings.
Currently, it does not do so for indices. Resolve that by telling
V8 explicitly to convert to string.

PR-URL: https://github.com/nodejs/node/pull/27524
Fixes: https://github.com/nodejs/node/issues/27496
Reviewed-By: Colin Ihrig 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ruben Bridgewater