delta/node-new.git/src/inspector_socket_server.h, branch pull-request-doc-updates

src: add missing `NODE_WANT_INTERNALS` guards

2018-08-28T14:54:07+00:00

We generally add these to all headers that are considered
internal to Node.

These aren’t distributed as part of the headers tarball,
so I think this does not have to be semver-major
(and we have been changing the APIs in these headers
freely anyway).

PR-URL: https://github.com/nodejs/node/pull/22514
Reviewed-By: James M Snell

inspector: split main thread interface from transport

2018-07-13T21:42:50+00:00

Workers debugging will require interfacing between the "main" inspector
and per-worker isolate inspectors. This is consistent with what WS
interface does. This change is a refactoring change and does not change
the functionality.

PR-URL: https://github.com/nodejs/node/pull/21182
Fixes: https://github.com/nodejs/node/issues/21725
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

inspector: use js_app.html as the landing page for chrome devtools

2018-06-28T12:24:02+00:00

As of this commit in chromium -
https://chromium-review.googlesource.com/c/chromium/src/+/905450
a new landing page (js_app.html) has been added and inspector.html
has been made as the fallback page.

Another motivation for this patch is the following bug in
chromium -
https://bugs.chromium.org/p/chromium/issues/detail?id=846642
due to which, source maps won't get applied with inspector.html,
but works with js_app.html

In order to maintain compatibility, this patch adds a URL
"devtoolsFrontendUrlCompat" to the response of /json/list REST API
so that those using Chrome browsers older than 66.0.3345.0
could use this to open DevTools.

PR-URL: https://github.com/nodejs/node/pull/21385
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=846642
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/905450
Reviewed-By: Aleksei Koziatinskii 
Reviewed-By: Jan Krems 
Reviewed-By: Matheus Marchini

inspector: code cleanup

2018-06-05T16:09:06+00:00

Remove some unused code from the WS server implementation and switch to
smart pointers where possible.

PR-URL: https://github.com/nodejs/node/pull/21070
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

inspector: report client-visible host and port

2018-04-02T17:20:30+00:00

Node instance may not know the real host and port user sees when
debug frontend connects through the SSH tunnel. This change fixes
'/json/list' response by using the value client provided in the host
header.

PR-URL: https://github.com/nodejs/node/pull/19664
Reviewed-By: Tiancheng "Timothy" Gu

inspector: Fix crash for WS connection

2017-12-11T23:53:21+00:00

Attaching WS session will now include a roundtrip onto the main thread
to make sure there is no other session (e.g. JS bindings)

This change also required refactoring WS socket implementation to better
support scenarios like this.

Fixes: https://github.com/nodejs/node/issues/16852
PR-URL: https://github.com/nodejs/node/pull/17085
Reviewed-By: James M Snell 
Reviewed-By: Timothy Gu

inspector: perform DNS lookup for host

2017-06-16T16:46:36+00:00

PR-URL: https://github.com/nodejs/node/pull/13478
Fixes: https://github.com/nodejs/node/issues/13477
Reviewed-By: Sam Roberts 
Reviewed-By: Refael Ackermann 
Reviewed-By: Ben Noordhuis

inspector: refactor to rename and comment methods

2017-06-01T22:54:34+00:00

Pure refactor, makes no functional changes but the renaming helped me
see more clearly what the relationship was between methods and
variables.

* Renamed methods to reduce number of slightly different names for the
  same thing ("thread" vs "io thread", etc.).
* Added comments where it was useful to me.

PR-URL: https://github.com/nodejs/node/pull/13321
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

inspector: fix process._debugEnd() for inspector

2017-05-22T18:18:31+00:00

This change ensures that the WebSocket server can be stopped
(and restarted if needed) buy calling process._debugEnd.

PR-URL: https://github.com/nodejs/node/pull/12777
Fixes: https://github.com/nodejs/node/issues/12559
Reviewed-By: Sam Roberts 
Reviewed-By: Refael Ackermann

inspector: no crash when WS server can't start

2017-01-20T17:10:37+00:00

This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: https://github.com/nodejs/node/issues/10858
PR-URL: https://github.com/nodejs/node/pull/10878
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig