delta/node-new.git/src/inspector_socket_server.cc, branch try_Python3_on_macOS

inspector: added --inspect-publish-uid

2019-06-03T15:15:04+00:00

This flag specifies how inspector websocket url should be reported.
Tthre options are supported:
- stderr - reports websocket as a message to stderr,
- http - exposes /json/list endpoint that contains inspector websocket
  url,
- binding - require('inspector').url().

Related discussion: https://github.com/nodejs/diagnostics/issues/303

PR-URL: https://github.com/nodejs/node/pull/27741
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Benjamin Gruenbaum

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

inspector: print all listening addresses

2019-03-04T01:19:27+00:00

Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.

No test. I can't think of a reliable way to test this on the CI matrix.

PR-URL: https://github.com/nodejs/node/pull/26008
Fixes: https://github.com/nodejs/node/issues/13772
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: James M Snell

src: apply clang-tidy rule modernize-use-override

2019-02-18T04:43:22+00:00

PR-URL: https://github.com/nodejs/node/pull/26103
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: use NULL check macros to check nullptr

2019-02-07T06:22:38+00:00

PR-URL: https://github.com/nodejs/node/pull/25916
Refs: https://github.com/nodejs/node/pull/20914
Reviewed-By: Masashi Hirano 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau

inspector: split main thread interface from transport

2018-07-13T21:42:50+00:00

Workers debugging will require interfacing between the "main" inspector
and per-worker isolate inspectors. This is consistent with what WS
interface does. This change is a refactoring change and does not change
the functionality.

PR-URL: https://github.com/nodejs/node/pull/21182
Fixes: https://github.com/nodejs/node/issues/21725
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

inspector: use js_app.html as the landing page for chrome devtools

2018-06-28T12:24:02+00:00

As of this commit in chromium -
https://chromium-review.googlesource.com/c/chromium/src/+/905450
a new landing page (js_app.html) has been added and inspector.html
has been made as the fallback page.

Another motivation for this patch is the following bug in
chromium -
https://bugs.chromium.org/p/chromium/issues/detail?id=846642
due to which, source maps won't get applied with inspector.html,
but works with js_app.html

In order to maintain compatibility, this patch adds a URL
"devtoolsFrontendUrlCompat" to the response of /json/list REST API
so that those using Chrome browsers older than 66.0.3345.0
could use this to open DevTools.

PR-URL: https://github.com/nodejs/node/pull/21385
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=846642
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/905450
Reviewed-By: Aleksei Koziatinskii 
Reviewed-By: Jan Krems 
Reviewed-By: Matheus Marchini

inspector: code cleanup

2018-06-05T16:09:06+00:00

Remove some unused code from the WS server implementation and switch to
smart pointers where possible.

PR-URL: https://github.com/nodejs/node/pull/21070
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

src: replace `template<` → `template <`

2018-05-14T16:09:23+00:00

PR-URL: https://github.com/nodejs/node/pull/20675
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ruben Bridgewater

inspector: allow concurrent inspector sessions

2018-04-26T19:48:48+00:00

This change enables concurrent inspector sessions, through WebSocket
interface as well as JS interface, in any combination.

PR-URL: https://github.com/nodejs/node/pull/20137
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Rich Trott