delta/node-new.git/src/inspector_agent.h, branch try_Python3_on_macOS

inspector: reduce InspectorIo API surface

2019-07-06T18:04:03+00:00

This is a cleanup, allowing for a better separation of concerns.

PR-URL: https://github.com/nodejs/node/pull/28526
Reviewed-By: Anna Henningsen 
Reviewed-By: Aleksei Koziatinskii 
Reviewed-By: Rich Trott

process: split routines used to enhance fatal exception stack traces

2019-06-27T12:22:08+00:00

Previously the enhancement were done right after emitting
`'uncaughtException'`, which meant by the time we knew the
exception was fatal in C++, the error.stack had already been
patched.

This patch moves those routines to be called later during the
fatal exception handling, and split them into two stages:
before and after the inspector is notified by the invocation of
`V8Inspector::exceptionThrown`. We now expand the stack to include
additional informations about unhandled 'error' events before
the inspector is notified, but delay the highlighting of the
frames until after the inspector is notified, so that the
ANSI escape sequences won't show up in the inspector console.

PR-URL: https://github.com/nodejs/node/pull/28308
Fixes: https://github.com/nodejs/node/issues/28287
Reviewed-By: Benjamin Gruenbaum

src: remove node_options-inl.h from header files

2019-05-05T04:24:17+00:00

Fix unnecessary inclusion of node_options-inl.h into env.h via
inspector_agent.h, causing almost all of src/ to recompile on any change
to the options parser. Its intended that *-inl.h header files are only
included into the src files that call the inline methods.

PR-URL: https://github.com/nodejs/node/pull/27538
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen

src: prefer v8::Global over node::Persistent

2019-04-29T22:23:33+00:00

`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.

PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann

src: de-lint header usage

2019-03-12T13:57:19+00:00

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

worker: set up child Isolate inside Worker thread

2019-02-11T18:57:19+00:00

Refs: https://github.com/nodejs/node/issues/24016

PR-URL: https://github.com/nodejs/node/pull/26011
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Joyee Cheung

inspector: split the HostPort being used and the one parsed from CLI

2018-12-08T22:26:53+00:00

Instead of using a shared pointer of the entire debug option set,
pass the parsed debug option to inspector classes by value because
they are set once the CLI argument parsing is done. Add another shared
pointer to HostPort being used by the inspector server, which is copied
from the one in the debug options initially. The port of the shared
HostPort is 9229 by default and can be specified as 0 initially but
will be set to the actual port of the server once it starts listening.

This makes the shared state clearer and makes it possible to use
`require('internal/options')` in JS land to query the CLI options
instead of using `process._breakFirstLine` and other underscored
properties of `process` since we are now certain that these
values should not be altered once the parsing is done and can be
passed around in copies without locks.

PR-URL: https://github.com/nodejs/node/pull/24772
Reviewed-By: Anna Henningsen

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani