delta/node-new.git/src/inspector, branch try_Python3_on_macOS

tools: sync gypfiles with V8 7.7

2019-08-19T07:26:07+00:00

Co-authored-by: Ujjwal Sharma 

PR-URL: https://github.com/nodejs/node/pull/28918
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Jiawen Geng 
Reviewed-By: Rich Trott

inspector: report all workers

2019-07-31T04:17:27+00:00

Main thread (the one that WS endpoint connects to) should be able
to report all workers.

PR-URL: https://github.com/nodejs/node/pull/28872
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: fix unused private field warning

2019-06-05T03:27:09+00:00

PR-URL: https://github.com/nodejs/node/pull/28036
Reviewed-By: Daniel Bevenius 
Reviewed-By: Michaël Zasso 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Sam Roberts 
Reviewed-By: Ruben Bridgewater

src: reorganize inspector and diagnostics initialization

2019-06-03T15:27:49+00:00

- Split the initialization of the inspector and other diagnostics
  into `Environment::InitializeInspector()` and
  `Environment::InitializeDiagnostics()` - these need to be
  reinitialized separately after snapshot deserialization.
- Do not store worker url alongside the inspector parent handle,
  instead just get it from the handle.
- Rename `Worker::profiler_idle_notifier_started_` to
  `Worker::start_profiler_idle_notifier_` because it stores
  the state inherited from the parent env to use for initializing
  itself.

PR-URL: https://github.com/nodejs/node/pull/27539
Reviewed-By: Anna Henningsen

inspector: supported NodeRuntime domain in worker

2019-06-02T19:37:11+00:00

NodeRuntime domain was introduced to give inspector client way to
fetch captured information before Node process is gone. We need
similar capability for work.

With current protocol inspector client can force worker to wait
on start by passing waitForDebuggerOnStart flag to NodeWorker.enable
method. So client has some time to setup environment, e.g. start
profiler. At the same time there is no way to prevent worker from
being terminated. So we can start capturing profile but we can not
reliably get captured data back.

This PR implemented NodeRuntime.notifyWhenWaitingForDisconnect
method for worker. When NodeRuntime.waitingForDisconnect notification
is enabled, worker will wait for explicit NodeWorker.detach call.

With this PR worker tooling story is nicely aligned with main thread
tooling story. The only difference is that main thread by default is
waiting for disconnect but worker thread is not waiting.

Issue: https://github.com/nodejs/node/issues/27677

PR-URL: https://github.com/nodejs/node/pull/27706
Reviewed-By: Eugene Ostroukhov

tools: update inspector_protocol to 0aafd2

2019-06-01T07:28:34+00:00

Co-authored-by: Ben Noordhuis 
PR-URL: https://github.com/nodejs/node/pull/27770
Reviewed-By: Ben Noordhuis 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Rich Trott

src: move DiagnosticFilename inlines into a -inl.h

2019-05-26T15:09:45+00:00

DiagnosticFilename's constructor default values use inlines from
env-inl.h, causing the many users of node_internals.h to include
env-inl.h, even if they never use DiagnosticFilename.

PR-URL: https://github.com/nodejs/node/pull/27839
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

inspector: added NodeRuntime domain

2019-05-14T23:13:57+00:00

Historically Node process sends Runtime.executionContextDestroyed
with main context as argument when it is finished.
This approach has some disadvantages. V8 prevents running some
protocol command on destroyed contexts, e.g. Runtime.evaluate
will return an error or Debugger.enable won't return a list of
scripts.
Both command might be useful for different tools, e.g. tool runs
Profiler.startPreciseCoverage and at the end of node process it
would like to get list of all scripts to match data to source code.
Or some tooling frontend would like to provide capabilities to run
commands in console when node process is finished to allow user to
inspect state of the program at exit.
This PR adds new domain: NodeRuntime. After
NodeRuntime.notifyWhenWaitingForDisconnect is enabled by at least one
client, node will send NodeRuntime.waitingForDebuggerToDisconnect
event instead of Runtime.executionContextDestroyed. Based on this
signal any protocol client can capture all required information and
then disconnect its session.

PR-URL: https://github.com/nodejs/node/pull/27600
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Rich Trott

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann