delta/node-new.git/src/handle_wrap.h, branch try_Python3_on_macOS

src: make ELDHistogram a HandleWrap

2019-09-08T03:57:35+00:00

This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: https://github.com/nodejs/node/pull/29317
Reviewed-By: James M Snell

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: add HandleWrap::AddWrapMethods

2018-07-13T16:08:20+00:00

Extracts common setters to a single location

PR-URL: https://github.com/nodejs/node/pull/21769
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

src: do proper error checking in `AsyncWrap::MakeCallback`

2018-06-13T22:43:45+00:00

At least one method on a native object is added as a getter,
namely `MessagePort.prototype.onmessage`. When a MessagePort
attempts to call this method from C++ in response to receiving
data, it will first invoke that getter and then call the function.

Since `worker.terminate()` interrupts execution, this means
that the getter may fail (without being faulty code on its own).
This means that at least one test exercising these methods in
combination has been flaky and could have crashed, because
we did not actually check that the getter returns a value
so far, resulting in dereferencing an empty `Local`.

The proper fix for this is to use the non-deprecated overload
of `Get()` and check the result like we should be doing.
Also, as a (related) fix, don’t crash if the method
is not a function but rather something else, like a getter
could provide.

Example test failure: https://ci.nodejs.org/job/node-test-commit-linux-containered/4976/nodes=ubuntu1604_sharedlibs_zlib_x64/console

    17:56:56 not ok 1955 parallel/test-worker-dns-terminate
    17:56:56   ---
    17:56:56   duration_ms: 1.237
    17:56:56   severity: crashed
    17:56:56   exitcode: -11
    17:56:56   stack: |-

PR-URL: https://github.com/nodejs/node/pull/21189
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: simplify handle closing

2018-06-06T17:43:41+00:00

Remove one extra closing state and use a smart pointer for
deleting `HandleWrap`s.

PR-URL: https://github.com/nodejs/node/pull/20876
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Shingo Inoue 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Gus Caplan

src: always call ReadStop() before Close()

2018-05-10T12:15:18+00:00

For libuv-backed streams, always explicitly stop reading before
closing the handle.

PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

src: make CleanupHandles() tear down handles/reqs

2018-05-10T12:15:16+00:00

Previously, handles would not be closed when the current `Environment`
stopped, which is acceptable in a single-`Environment`-per-process
situation, but would otherwise create memory and file descriptor
leaks.

Also, introduce a generic way to close handles via the
`Environment::CloseHandle()` function, which automatically keeps
track of whether a close callback has been called yet or not.

Many thanks for Stephen Belanger for reviewing the original version of
this commit in the Ayo.js project.

Refs: https://github.com/ayojs/ayo/pull/85
PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

src: remove unnecessary Reset() calls

2018-02-21T14:24:18+00:00

The previous commit made persistent handles auto-reset on destruction.
This commit removes the Reset() calls that are now no longer necessary.

PR-URL: https://github.com/nodejs/node/pull/18656
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: do not redefine private for GenDebugSymbols

2018-02-14T08:55:15+00:00

Redefining private breaks any private inheritance in the
included files. We can simply declare GenDebugSymbols()
as friends in related classes to gain the access that we need.

PR-URL: https://github.com/nodejs/node/pull/18653
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src, test: node internals' postmortem metadata

2018-01-26T00:55:36+00:00

Before these changes, only V8 added postmortem metadata to Node's
binary, limiting the possibilities for debugger's developers to add some
features that rely on investigating Node's internal structures.

These changes are first steps towards empowering debug tools to
navigate Node's internal structures. One example of what can be
achieved with this is shown at nodejs/llnode#122 (a command which prints
information about handles and requests on the queue for a core dump
file). Node postmortem metadata are prefixed with nodedbg_.

This also adds tests to validate if all postmortem metadata are
calculated correctly, plus some documentation on what is postmortem
metadata and a few care to be taken to avoid breaking it.

Ref: https://github.com/nodejs/llnode/pull/122
Ref: https://github.com/nodejs/post-mortem/issues/46

PR-URL: https://github.com/nodejs/node/pull/14901
Refs: https://github.com/nodejs/post-mortem/issues/46
Reviewed-By: Michael Dawson 
Reviewed-By: Matteo Collina 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung