delta/node-new.git/src/env.cc, branch try_Python3_on_macOS

Revert "src: remove trace_sync_io_ from env"

2019-08-04T03:41:50+00:00

This reverts commit 7fa5f54e6f2854183e45e0e105a1e22a381aac60.

The reverted commit breaks the logic behind --trace-sync-io, it should
be enabled only at a certain point in time, while that commit enables
it from the very start, causing warnings be printed for all sync io
instead of sync io after the first tick of the event loop as documented.

Fixes: https://github.com/nodejs/node/issues/28913
Refs: https://github.com/nodejs/node/pull/22726
Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
PR-URL: https://github.com/nodejs/node/pull/28926
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: allow generic C++ callables in SetImmediate()

2019-07-31T22:51:43+00:00

Modify the native `SetImmediate()` functions to take generic C++
callables as arguments. This makes passing arguments to the callback
easier, and in particular, it allows passing `std::unique_ptr`s
directly, which in turn makes sure that the data they point to is
deleted if the `Environment` is torn down before the callback can run.

PR-URL: https://github.com/nodejs/node/pull/28704
Reviewed-By: James M Snell

src: export v8.GetHeapCodeAndMetadataStatistics()

2019-07-30T18:36:51+00:00

Export statistic provided by V8 through HeapCodeStatistics class and
and GetHeapCodeAndMetadataStatistics function to v8 Node.js module

PR-URL: https://github.com/nodejs/node/pull/27978
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: Rich Trott

src: fix OpenBSD build

2019-07-30T06:27:12+00:00

PR-URL: https://github.com/nodejs/node/pull/28384
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rich Trott

src: do not include partial AsyncWrap instances in heap dump

2019-07-22T23:41:22+00:00

Heap dumps can be taken either through the inspector or the public API
for it during an async_hooks init() hook, but at that point the
AsyncWrap in question is not done initializing yet and virtual methods
cannot be called on it.

Address this issue (somewhat hackily) by excluding `AsyncWrap`
instances which have not yet executed their `init()` hook fully
from heap dumps.

Fixes: https://github.com/nodejs/node/issues/28786

PR-URL: https://github.com/nodejs/node/pull/28789
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rich Trott

src: make `CompiledFnEntry` a `BaseObject`

2019-07-22T18:55:25+00:00

In particular:

- Move the class definition to the relevant header file,
  i.e. `node_contextify.h`.
- Make sure that class instances are destroyed on
  `Environment` teardown.
- Make instances of the key object traceable in heap dumps. This is
  particularly relevant here because our C++ script → map key mapping
  could introduce memory leaks when the import function metadata refers
  back to the script in some way.

Refs: https://github.com/nodejs/node/pull/28671

PR-URL: https://github.com/nodejs/node/pull/28782
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott

vm: fix gc bug with modules and compiled functions

2019-07-19T21:45:46+00:00

PR-URL: https://github.com/nodejs/node/pull/28671
Reviewed-By: Anna Henningsen 
Reviewed-By: Guy Bedford

src: refactor uncaught exception handling

2019-06-19T08:16:37+00:00

The C++ land `node::FatalException()` is not in fact fatal anymore.
It gives the user a chance to handle the uncaught exception
globally by listening to the `uncaughtException` event. This patch
renames it to `TriggerUncaughtException` in C++ to avoid the confusion.

In addition rename the JS land handler to `onGlobalUncaughtException`
to reflect its purpose - we have to keep the alias
`process._fatalException` and use that for now since it has been
monkey-patchable in the user land.

This patch also

- Adds more comments to the global uncaught exception handling routine
- Puts a few other C++ error handling functions into the `errors`
  namespace
- Moves error-handling-related bindings to the `errors` binding.

Refs: https://github.com/nodejs/node/commit/2b252acea47af3ebeac3d7e68277f015667264cc

PR-URL: https://github.com/nodejs/node/pull/28257
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Franziska Hinkelmann

src: save exec path when initializing Environment

2019-06-19T03:25:24+00:00

PR-URL: https://github.com/nodejs/node/pull/28252
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: fix off-by-one error in native SetImmediate

2019-06-14T11:03:11+00:00

Previously, the throwing callback would have been re-executed in case
of an exception. This patch corrects the calculation to exclude the
callback.

PR-URL: https://github.com/nodejs/node/pull/28082
Fixes: https://github.com/nodejs/node/issues/26754
Reviewed-By: Michael Dawson 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: James M Snell