delta/node-new.git/src/connection_wrap.cc, branch pull-request-doc-updates

src: pass along errors from stream obj instantiation

2019-01-29T19:01:59+00:00

PR-URL: https://github.com/nodejs/node/pull/25734
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: make req_wrap a unique_ptr in AfterConnect

2018-10-01T06:26:30+00:00

PR-URL: https://github.com/nodejs/node/pull/23115
Reviewed-By: Gireesh Punathil 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26T10:29:31+00:00

This change introduces CHECK_NULL and CHECK_NOT_NULL macros
similar to their definition in v8 and replaces instances of
CHECK/CHECK_EQ/CHECK_NE with these where it seems appropriate.

PR-URL: https://github.com/nodejs/node/pull/20914
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

src: don't create Undefined if not needed

2018-05-09T08:15:06+00:00

This commit moves the creation of argv and only creates an undefined
value if the passed in status was not 0.

The variable name client_handle was already used in this function but
I've change that usage so that this variable name matches the
onconnection callback functions parameter name clientHandle.

PR-URL: https://github.com/nodejs/node/pull/20573
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen

src: add node_internal.h includes for arraysize

2018-04-12T13:28:11+00:00

This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).

PR-URL: https://github.com/nodejs/node/pull/19916
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gibson Fahnestock

src: refactor stream callbacks and ownership

2018-02-01T09:53:26+00:00

Instead of setting individual callbacks on streams and tracking
stream ownership through a boolean `consume_` flag, always have
one specific listener object in charge of a stream, and call
methods on that object rather than generic C-style callbacks.

PR-URL: https://github.com/nodejs/node/pull/18334
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Matteo Collina

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19T17:04:52+00:00

Previously the getter would mutate the kDefaultTriggerAsncId value. This
refactor changes the setter to bind the current kDefaultTriggerAsncId to
a scope, such that the getter doesn't have to mutate its own value.

PR-URL: https://github.com/nodejs/node/pull/17273
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

async_hooks: rename initTriggerId

2017-12-19T17:04:43+00:00

rename initTriggerId to defaultTriggerAsyncId such it matches the rest
of our naming.

PR-URL: https://github.com/nodejs/node/pull/17273
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

async_wrap: add provider types for net server

2017-11-28T01:50:54+00:00

Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

PR-URL: https://github.com/nodejs/node/pull/17157
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen