delta/node-new.git/src/callback_scope.cc, branch crypto_set_integer_macro

src: refactor `Environment::GetCurrent()` usage

2018-09-17T15:20:27+00:00

Make `Environment::GetCurrent()` return `nullptr` if the current
`Context` is not a Node.js context, and for the relevant usage of
this function, either:

- Switch to the better `GetCurrent(args)` variant
- Turn functions in to no-ops where it makes sense
- Make it a `CHECK`, i.e. an API requirement, where it make sense
- Leave a `TODO` comment for verifying what, if anything, is to be done

PR-URL: https://github.com/nodejs/node/pull/22819
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Refael Ackermann

src: yield empty maybes for failed AsyncWrap::MakeCallback calls

2018-08-12T17:03:43+00:00

Use an empty `MaybeLocal` as the return value for
`AsyncWrap::MakeCallback()` if an exception occurred,
regardless of `MakeCallback` depth.

Unfortunately, the public API can not make this switch without
a breaking change (and possibly some kind of deprecation/renaming).

PR-URL: https://github.com/nodejs/node/pull/22078
Reviewed-By: Joyee Cheung 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Jon Moss

src: remove tick_info->has_thrown

2018-06-25T04:35:11+00:00

This is no longer necessary in the only place it was used (timers).

PR-URL: https://github.com/nodejs/node/pull/20894
Fixes: https://github.com/nodejs/node/issues/10154
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Matteo Collina 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Gus Caplan

src: remove .h if -inl.h is already included

2018-06-20T03:42:39+00:00

This commit removes the normal header file include if an internal one
is specified as per the CPP_STYLE_GUIDE.

PR-URL: https://github.com/nodejs/node/pull/21381
Reviewed-By: Matheus Marchini 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ujjwal Sharma

worker: initial implementation

2018-06-06T17:43:52+00:00

Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: https://github.com/ayojs/ayo/pull/110
Refs: https://github.com/ayojs/ayo/pull/114
Refs: https://github.com/ayojs/ayo/pull/117

PR-URL: https://github.com/nodejs/node/pull/20876
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Shingo Inoue 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Gus Caplan

src: add CHECK_IMPLIES macro

2018-05-26T10:29:12+00:00

This change introduces the CHECK_IMPLIES macro
similar to its definition in v8 and replaces instances of
CHECK with CHECK_IMPLIES where it seems appropriate.

PR-URL: https://github.com/nodejs/node/pull/20914
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

src: re-integrate headers into node.h

2018-05-24T15:49:23+00:00

Alternative to https://github.com/nodejs/node/pull/20938
(clean revert) and https://github.com/nodejs/node/pull/20925
(adding the headers to the release tarball).

The changes to `src/node.h` are a clean revert in the
same ways as https://github.com/nodejs/node/pull/20938 does it,
the difference being that the new `.cc` files are kept here.

This has the advantage of not being another large diff that
other PRs will have to rebase against, especially since
the split into `callback_scope.cc` and `exceptions.cc` is
something that we want to keep in the long run.

This essentialy implements bnoordhuis’s suggestion from
https://github.com/nodejs/node/pull/20925.

PR-URL: https://github.com/nodejs/node/pull/20939
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Refael Ackermann

src: move CallbackScope to separate cc/h

2018-05-19T17:41:41+00:00

PR-URL: https://github.com/nodejs/node/pull/20789
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu