delta/node-new.git/src/base64.h, branch try_Python3_on_macOS

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: change macro to fn

2018-10-15T13:38:36+00:00

Change base64_encoded_size and unbase64 to inline functions. The
base64_encoded_size is a constexpr to be used in function declarations.

PR-URL: https://github.com/nodejs/node/pull/23603
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani

src: make base64.h self-contained

2017-11-27T06:21:08+00:00

This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.

PR-URL: https://github.com/nodejs/node/pull/17177
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Alexey Orlenko 
Reviewed-By: Timothy Gu

src: fix decoding base64 with whitespace

2017-06-16T16:09:50+00:00

`max_i` should also include the characters that were just read by
`base64_decode_group_slow()`.

PR-URL: https://github.com/nodejs/node/pull/13660
Fixes: https://github.com/nodejs/node/issues/13636
Fixes: https://github.com/nodejs/node/issues/13657
Reviewed-By: James M Snell 
Reviewed-By: Alexey Orlenko 
Reviewed-By: Colin Ihrig

buffer: optimize decoding wrapped base64 data

2017-04-04T16:42:44+00:00

The fast base64 decoder used to switch to the slow one permanently when
it saw a whitespace or other garbage character.  Since the most common
situation such characters may be encountered in is line-wrapped base64
data, a more profitable strategy is to decode a single 24-bit group with
the slow decoder and then continue running the fast algorithm.

PR-URL: https://github.com/nodejs/node/pull/12146
Ref: https://github.com/nodejs/node/issues/12114
Reviewed-By: Anna Henningsen 
Reviewed-By: Trevor Norris 
Reviewed-By: James M Snell

src: fix base64 decoding

2017-03-31T20:00:02+00:00

Make sure trailing garbage is not treated as a valid base64 character.

Fixes: https://github.com/nodejs/node/issues/11987
PR-URL: https://github.com/nodejs/node/pull/11995
Reviewed-By: Anna Henningsen

string_bytes: Make base64 encode/decode reusable

2016-05-23T22:52:49+00:00

Node already has support for base64 encoding and decoding that is not
visible outside the string_bytes.cc file. Our work on providing a
support for the Chrome inspector protocol
(https://github.com/nodejs/node/pull/6792) requires base64 encoding
support. Rather then introducing a second copy of the base64 encoder,
we suggest moving this code into a separate header.

PR-URL: https://github.com/nodejs/node/pull/6910
Reviewed-By: bnoordhuis - Ben Noordhuis 
Reviewed-By: indutny - Fedor Indutny 
Reviewed-By: ofrobots - Ali Ijaz Sheikh