delta/node-new.git/src/api/environment.cc, branch docs-fix

worker: fix --abort-on-uncaught-exception handling

2020-08-11T21:58:50+00:00

The `set_abort_on_uncaught_exception(false)` line was supposed to
prevent aborting when running Workers in
`--abort-on-uncaught-exception` mode, but it was incorrectly set
and not checked properly in the should-abort callback.

PR-URL: https://github.com/nodejs/node/pull/34724
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Mary Marchini

src: allow preventing SetPromiseRejectCallback

2020-07-21T15:46:05+00:00

PR-URL: https://github.com/nodejs/node/pull/34387
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: snapshot Environment upon instantiation

2020-07-18T03:15:57+00:00

This includes the initial Environment (without running bootstrap
scripts) into the builtin snapshot

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src: split the main context initialization from Environemnt ctor

2020-07-18T03:02:56+00:00

So that it's possible to create an Environment not yet attached
to any V8 context. We'll use this to deserialize the V8 context
before attaching an Environment to it.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src,doc,test: remove String::New default parameter

2020-07-14T13:13:34+00:00

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell

lib,src: remove cpu profiler idle notifier

2020-06-25T18:52:53+00:00

I added it in commit 57231d5286 ("src: notify V8 profiler when we're
idle") from October 2013 as a stop-gap measure to measure CPU time
rather than wall clock time, otherwise processes that spend a lot
of time sleeping in system calls give a false impression of being
very busy.

That fix is not without drawbacks because the idle flag is set before
libuv makes I/O callbacks and cleared again after. I/O callbacks can
result into calls into JS code and executing JS code is as non-idle
as you can get.

In commit 96ffcb9a21 ("src: reduce cpu profiler overhead") from January
2015, I made Node.js block off the SIGPROF signal that V8's CPU profiler
uses before Node.js goes to sleep. The goal of that commit is to reduce
the overhead from EINTR system call wakeups but it also has the pleasant
side effect of fixing what the idle notifier tried to fix.

This commit removes the idle notifier and turns the JS process object
methods into no-ops.

Fixes: https://github.com/nodejs/node/issues/19009
Refs: https://github.com/nodejs/node/pull/33138

PR-URL: https://github.com/nodejs/node/pull/34010
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: disallow JS execution inside FreeEnvironment

2020-06-25T00:43:29+00:00

This addresses a TODO comment, and aligns the behavior between
worker threads and the main thread.

The primary motivation for this change is to more strictly enforce
the invariant that no JS runs after the `'exit'` event is emitted.

PR-URL: https://github.com/nodejs/node/pull/33874
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Shelley Vohr

src: use Check() instead of FromJust in environment

2020-06-08T04:20:50+00:00

This commit replaces FromJust() calls with Check() in places where the
value that FromJust() returns is not used.

PR-URL: https://github.com/nodejs/node/pull/33706
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier

process: use v8 fast api calls for hrtime

2020-06-06T16:55:45+00:00

Refs: https://github.com/nodejs/node/issues/33374

PR-URL: https://github.com/nodejs/node/pull/33600
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

src: use MaybeLocal.ToLocal instead of IsEmpty

2020-05-28T04:14:48+00:00

This commit suggest using MaybeLocal.ToLocal and passing in the
Local fn.

The motivation for doing this is that the following
MaybeLocal.ToLocalChecked call can then be avoided.

PR-URL: https://github.com/nodejs/node/pull/33554
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell