delta/node-new.git/src/api/callback.cc, branch docs-fix

src,doc,test: remove String::New default parameter

2020-07-14T13:13:34+00:00

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell

async_hooks: improve resource stack performance

2020-07-14T11:14:27+00:00

Removes some of the performance overhead that came with
`executionAsyncResource()` by using the JS resource array
only as a cache for the values provided by C++. The fact that we now
use an entry trampoline is used to pass the resource without
requiring extra C++/JS boundary crossings, and the direct accesses
to the JS resource array from C++ are removed in all fast paths.

This particularly improves performance when async hooks are not
being used.

This is a continuation of https://github.com/nodejs/node/pull/33575
and shares some of its code with it.

    ./node benchmark/compare.js --new ./node --old ./node-master --runs 30 --filter messageport worker | Rscript benchmark/compare.R
    [00:06:14|% 100| 1/1 files | 60/60 runs | 2/2 configs]: Done
                                                       confidence improvement accuracy (*)    (**)   (***)
     worker/messageport.js n=1000000 payload='object'         **     12.64 %       ±7.30%  ±9.72% ±12.65%
     worker/messageport.js n=1000000 payload='string'          *     11.08 %       ±9.00% ±11.98% ±15.59%

    ./node benchmark/compare.js --new ./node --old ./node-master --runs 20 --filter async-resource-vs-destroy async_hooks | Rscript benchmark/compare.R
    [00:22:35|% 100| 1/1 files | 40/40 runs | 6/6 configs]: Done
                                                                                                                                                                         confidence improvement accuracy (*)
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-local-storage' benchmarker='autocannon'                     1.60 %       ±7.35%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-resource' benchmarker='autocannon'                          6.05 %       ±6.57%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='destroy' benchmarker='autocannon'                          *      8.27 %       ±7.50%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-local-storage' benchmarker='autocannon'                 7.42 %       ±8.22%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-resource' benchmarker='autocannon'                      4.33 %       ±7.84%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='destroy' benchmarker='autocannon'                             5.96 %       ±7.15%
                                                                                                                                                                           (**)   (***)
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-local-storage' benchmarker='autocannon'      ±9.84% ±12.94%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-resource' benchmarker='autocannon'           ±8.81% ±11.60%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='destroy' benchmarker='autocannon'                 ±10.07% ±13.28%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-local-storage' benchmarker='autocannon' ±11.01% ±14.48%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-resource' benchmarker='autocannon'      ±10.50% ±13.81%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='destroy' benchmarker='autocannon'              ±9.58% ±12.62%

Refs: https://github.com/nodejs/node/pull/33575

PR-URL: https://github.com/nodejs/node/pull/34319
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Stephen Belanger

domain: remove native domain code

2020-06-19T15:37:26+00:00

With the async_hooks callback trampoline, domains no longer need any
native code. With this, domains can exist in pure JavaScript.

PR-URL: https://github.com/nodejs/node/pull/33801
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Gus Caplan 
Reviewed-By: Andrey Pechkurov 
Reviewed-By: Gerhard Stöbich

async_hooks: callback trampoline for MakeCallback

2020-06-19T15:37:25+00:00

PR-URL: https://github.com/nodejs/node/pull/33801
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Gus Caplan 
Reviewed-By: Andrey Pechkurov 
Reviewed-By: Gerhard Stöbich

src: use symbol to store `AsyncWrap` resource

2020-05-22T00:45:09+00:00

Use a symbol on the bindings object to store the public resource object,
rather than a `v8::Global` Persistent. This has several advantages:

- It’s harder to inadvertently create memory leaks this way.
  The garbage collector sees the `AsyncWrap` →  resource link like
  a regular JS property, and can collect the objects as a group,
  even if the resource object should happen to point back to the
  `AsyncWrap` object.
- This will make it easier in the future to use `owner_symbol` for
  this purpose, which is generally the direction we should be moving
  the `async_hooks` API into (i.e. using more public objects instead
  of letting internal wires stick out).

PR-URL: https://github.com/nodejs/node/pull/31745
Reviewed-By: Stephen Belanger 
Reviewed-By: David Carlier 
Reviewed-By: Denys Otrishko 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Gerhard Stöbich

async_hooks: clear async_id_stack for terminations in more places

2020-05-15T17:38:25+00:00

Termination exceptions are similar to uncaught exceptions in that they
should clear the async id stack, because no ongoing async callbacks
will be brought to completion when execution terminates.

Previously, there was a check that made sure that that happened when
the termination occurred during the callback itself, but no such check
was in place for the case that the termination occurred during
microtasks started by them. This commit adds such a check, both for
microtasks and the `nextTick` queue. The latter addition doesn’t fix
a crash, but still makes sense conceptually.

The condition here is also flipped from applying only on Worker threads
to also applying on the main thread, and setting the `failed_` flag
rather than reading it. The former makes sense because the public C++
`Stop(env)` API can have the same effect as worker thread termination,
but on the main thread rather than a Worker thread.

PR-URL: https://github.com/nodejs/node/pull/33347
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: David Carlier

src: pass resource object along with InternalMakeCallback

2020-03-04T22:20:57+00:00

This was an oversight in 9fdb6e6aaf45b2364bac89a.
Fixing this is necessary to make `executionAsyncResource()` work
as expected.

Refs: https://github.com/nodejs/node/pull/30959
Fixes: https://github.com/nodejs/node/issues/32060

PR-URL: https://github.com/nodejs/node/pull/32063
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Stephen Belanger 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell

async_hooks: executionAsyncResource matches in hooks

2020-02-26T13:58:21+00:00

Ensure that resource returned by executionAsyncResource() in before
and after hook matches that resource causing this before/after calls.

PR-URL: https://github.com/nodejs/node/pull/31821
Refs: https://github.com/nodejs/node/pull/30959
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Stephen Belanger 
Reviewed-By: Vladimir de Turckheim

async_hooks: add executionAsyncResource

2020-02-11T19:59:09+00:00

Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger 
PR-URL: https://github.com/nodejs/node/pull/30959
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell

src: remove dead code in InternalMakeCallback

2020-02-08T14:17:42+00:00

Remove unneeded condition as the first line in function already
ensures that recv can't be empty.

PR-URL: https://github.com/nodejs/node/pull/31622
Reviewed-By: Chengzhong Wu 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yihong Wang 
Reviewed-By: Ruben Bridgewater