delta/node-new.git/lib, branch pull-request-doc-updates

child_process: close pipe ends that are re-piped

2019-02-06T12:20:46+00:00

when t0 and t1 are spawned with t0's outputstream [1, 2] is piped into
t1's input, a new pipe is created which uses a copy of the t0's fd.
This leaves the original copy in Node parent, unattended. Net result is
that when t0 produces data, it gets bifurcated into both the copies

Detect the passed handle to be of 'wrap' type and close after the
native spawn invocation by which time piping would have been over.

Fixes: https://github.com/nodejs/node/issues/9413
Fixes: https://github.com/nodejs/node/issues/18016

PR-URL: https://github.com/nodejs/node/pull/21209
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

repl: remove obsolete buffer clearing

2019-02-06T06:37:48+00:00

It is checked if an command buffer exists or not. This code branch
can only be reached if none exist, so there's no need to clear that
buffer again.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

repl: fix eval return value

2019-02-06T06:30:39+00:00

In case no error has occurred during the evaluation of some code,
`undefined` has been returned in some cases as error argument instead
of `null`. This is fixed by this patch.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

repl: simplify and improve completion

2019-02-06T06:30:28+00:00

The completion lists used a hand crafted list of global entries that
was redundant due to also using the actual global properties for tab
completion. Those entries ended up in an separated completion group
which did not seem useful.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

process: stub unsupported worker methods

2019-02-05T23:50:10+00:00

Some process methods are not supported in workers. This commit
adds stubs that throw more informative errors.

PR-URL: https://github.com/nodejs/node/pull/25587
Fixes: https://github.com/nodejs/node/issues/25448
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell

tls: in-line comments and other cleanups

2019-02-05T23:17:53+00:00

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

tls: don't shadow the tls global with a local

2019-02-05T23:16:39+00:00

`tls` shadows the global `tls` require, and isn't indicative of the
arument type.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

src: split ownsProcessState off isMainThread

2019-02-05T20:55:54+00:00

Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with `Worker`s.

Previously, the `isMainThread` flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.

PR-URL: https://github.com/nodejs/node/pull/25881
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

tls: check arg types of renegotiate()

2019-02-04T16:06:41+00:00

Don't throw on invalid property access if options is not provided, and
ensure callback is a function.

PR-URL: https://github.com/nodejs/node/pull/25876
Reviewed-By: Anna Henningsen 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig

src,lib: remove dead `process.binding()` code

2019-02-03T19:41:53+00:00

There are no non-internal builtin modules left, so this
should be safe to remove to a large degree.

PR-URL: https://github.com/nodejs/node/pull/25829
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anto Aravinth 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis