delta/node-new.git/lib, branch ofrobots-patch-1

util: treat format arguments equally

2018-10-17T17:56:43+00:00

Two changes here which bring us closer to the console standard:

- Arguments to `util.format` are no longer formatted differently
  depending on their order, with format strings being an exception.
- Format specifier formatting is now only triggered if the string
  actually contains a format string.

Under the hood, we now use a single shared function to format the given
arguments which will make the code easier to read and modify.

PR-URL: https://github.com/nodejs/node/pull/23162
Fixes: https://github.com/nodejs/node/issues/23137
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

tls: prevent multiple connection errors

2018-10-17T16:51:20+00:00

onConnectEnd(), which is called by TLSSocket, has a guard to
prevent being called multiple times, but it does not prevent the
OpenSSL error handler from being called, leading to multiple
error events. This commit adds that piece of missing logic.

PR-URL: https://github.com/nodejs/node/pull/23636
Fixes: https://github.com/nodejs/node/issues/23631
Reviewed-By: Anna Henningsen 
Reviewed-By: Wyatt Preul 
Reviewed-By: James M Snell

src: remove function hasTextDecoder in encoding.js

2018-10-16T17:08:22+00:00

also... return TextDecoder directly from factories

PR-URL: https://github.com/nodejs/node/pull/23625
Reviewed-By: Anna Henningsen 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sakthipriyan Vairamani

async_hooks: remove promise object from resource

2018-10-15T18:40:51+00:00

While it doesn't make any difference now. In the future PromiseHooks
could be refactored to provide an asyncId instead of the promise object.
That would make escape analysis on promises possible.

Escape analysis on promises could lead to a more efficient destroy hook,
if provide by PromiseHooks as well. But at the very least would allow
the destroy hook to be emitted earlier. The destroy hook not being
emitted on promises frequent enough is a known and reported issue.
See https://github.com/nodejs/node/issues/14446 and
https://github.com/Jeff-Lewis/cls-hooked/issues/11.

While all this is speculation for now, it all depends on the promise
object not being a part of the PromiseWrap resource object.

Ref: https://github.com/nodejs/node/issues/14446
Ref: https://github.com/nodejs/diagnostics/issues/188

PR-URL: https://github.com/nodejs/node/pull/23443
Refs: https://github.com/nodejs/node/issues/14446
Refs: https://github.com/nodejs/diagnostics/issues/188
Reviewed-By: Benedikt Meurer 
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: George Adams

module: removed unused variable

2018-10-15T13:34:45+00:00

The variable problemChecking was not used. Removed it.

PR-URL: https://github.com/nodejs/node/pull/23624
Reviewed-By: Anna Henningsen 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ruben Bridgewater

buffer: move process.binding('buffer') to internalBinding

2018-10-15T11:01:20+00:00

PR-URL: https://github.com/nodejs/node/pull/22370
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

lib: migrate process.binding to internalBinding

2018-10-15T10:00:00+00:00

PR-URL: https://github.com/nodejs/node/pull/23517
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

lib: migrate process.binding to getOptions

2018-10-15T10:00:00+00:00

PR-URL: https://github.com/nodejs/node/pull/23522
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

lib: migrate process.binding('config') to getOptions()

2018-10-15T10:00:00+00:00

PR-URL: https://github.com/nodejs/node/pull/23526
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

lib: removed unused variable

2018-10-15T10:00:00+00:00

This change removes a variable that is not being used in the file.

PR-URL: https://github.com/nodejs/node/pull/23497
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Guy Bedford 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater