delta/node-new.git/lib, branch devsnek-patch-1

lib: refactor to use more primordials

2020-11-19T18:18:14+00:00

PR-URL: https://github.com/nodejs/node/pull/36140
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: add support for TypedArray to getUnpackedSettings

2020-11-19T17:48:02+00:00

PR-URL: https://github.com/nodejs/node/pull/36141
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

lib: set abort-controller toStringTag

2020-11-19T15:56:51+00:00

PR-URL: https://github.com/nodejs/node/pull/36115
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

http: add support for abortsignal to http.request

2020-11-19T14:32:44+00:00

PR-URL: https://github.com/nodejs/node/pull/36048
Reviewed-By: Anna Henningsen 
Reviewed-By: Denys Otrishko 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott

lib: remove primordials.SafePromise

2020-11-19T12:33:43+00:00

PR-URL: https://github.com/nodejs/node/pull/36149
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca

lib: add throws option to fs.f/l/statSync

2020-11-18T21:19:33+00:00

For consumers that aren't interested in *why* a `statSync` call failed,
allocating and throwing an exception is an unnecessary expense.  This PR
adds an option that will cause it to return `undefined` in such cases
instead.

As a motivating example, the JavaScript & TypeScript language service
shared between Visual Studio and Visual Studio Code is stuck with
synchronous file IO for architectural and backward-compatibility
reasons.  It frequently needs to speculatively check for the existence
of files and directories that may not exist (and cares about file vs
directory, so `existsSync` is insufficient), but ignores file system
entries it can't access, regardless of the reason.

Benchmarking the language service is difficult because it's so hard to
get good coverage of both code bases and user behaviors, but, as a
representative metric, we measured batch compilation of a few hundred
popular projects (by star count) from GitHub and found that, on average,
we saved about 1-2% of total compilation time.  We speculate that the
savings could be even more significant in interactive (language service
or watch mode) scenarios, where the same (non-existent) files need to be
polled over and over again.  It's not a huge improvement, but it's a
very small change and it will affect a lot of users (and CI runs).

For reference, our measurements were against `v12.x` (3637a061a at the
time) on an Ubuntu Server desktop with an SSD.

PR-URL: https://github.com/nodejs/node/pull/33716
Reviewed-By: Denys Otrishko 
Reviewed-By: Joyee Cheung

domain: improve deprecation warning text for DEP0097

2020-11-18T18:58:49+00:00

Because the following gives basically no actionable information
on its own, neither in the error message nor in the stack trace:

    (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
        at emitMakeCallbackDeprecation (domain.js:123:13)
        at process.topLevelDomainCallback (domain.js:135:5)
        at process.callbackTrampoline (internal/async_hooks.js:124:14)

PR-URL: https://github.com/nodejs/node/pull/36136
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Rich Trott

fs: filehandle read now accepts object as argument

2020-11-18T18:50:44+00:00

PR-URL: https://github.com/nodejs/node/pull/34180
Fixes: https://github.com/nodejs/node/issues/34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang 
Reviewed-By: Antoine du Hamel

timers: refactor to use more primordials

2020-11-18T12:21:24+00:00

PR-URL: https://github.com/nodejs/node/pull/36132
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca

events: add max listener warning for EventTarget

2020-11-16T09:48:18+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/36001
Fixes: https://github.com/nodejs/node/issues/35990
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott