delta/node-new.git/lib/util.js, branch devsnek-patch-1

tools: add new ESLint rule: prefer-primordials

2020-11-07T10:28:14+00:00

I added a new custom ESLint rule to fix these problems.

We have a lot of replaceable codes with primordials.
Accessing built-in objects is restricted by existing rule
(no-restricted-globals), but accessing property in the built-in objects
is not restricted right now. We manually review codes that can be
replaced by primordials, but there's a lot of code that actually needs
to be fixed. We have often made pull requests to replace the primordials
with.

Restrict accessing global built-in objects such as `Promise`.
Restrict calling static methods such as `Array.from` or `Symbol.for`.
Don't restrict prototype methods to prevent false-positive.

PR-URL: https://github.com/nodejs/node/pull/35448
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Ben Coe

util: add debug and debuglog.enabled

2020-08-10T17:09:43+00:00

PR-URL: https://github.com/nodejs/node/pull/33424
Reviewed-By: James M Snell

lib: replace use of Error with primordials

2020-01-04T22:50:18+00:00

PR-URL: https://github.com/nodejs/node/pull/31163
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

lib: use static Number properties from primordials

2019-11-30T12:45:38+00:00

PR-URL: https://github.com/nodejs/node/pull/30686
Reviewed-By: Trivikram Kamat 
Reviewed-By: Anna Henningsen

lib: enforce use of Array from primordials

2019-11-27T18:29:01+00:00

PR-URL: https://github.com/nodejs/node/pull/30635
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05T20:59:32+00:00

PR-URL: https://github.com/nodejs/node/pull/29834
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

lib: require globals instead of using the global proxy

2019-04-15T20:24:26+00:00

In addition, use process.stderr instead of console.error when
there is no need to swallow the error.

PR-URL: https://github.com/nodejs/node/pull/27112
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

lib: use safe methods from primordials

2019-04-08T09:23:09+00:00

This changes the primordials to expose built-in prototypes with their
methods already uncurried.
The uncurryThis function is therefore moved to the primordials.
All uses of uncurryThis on built-ins are changed to import the relevant
prototypes from primordials.
All uses of Function.call.bind are also changed to use primordials.

PR-URL: https://github.com/nodejs/node/pull/27096
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung