delta/node-new.git/lib/url.js, branch try_Python3_on_macOS

tools: enable block-scoped-var eslint rule

2019-05-10T14:58:49+00:00

PR-URL: https://github.com/nodejs/node/pull/27616
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

benchmark,lib: change var to const

2019-03-30T12:16:39+00:00

Refs: https://github.com/nodejs/node/pull/26679

PR-URL: https://github.com/nodejs/node/pull/26915
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann

url: add ws: and wss: to slashedProtocol set

2019-03-30T12:05:31+00:00

Fix cases where the pathname is incorrectly parsed as `null`.

PR-URL: https://github.com/nodejs/node/pull/26941
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yongsheng Zhang

benchmark,doc,lib: capitalize more comments

2019-03-27T16:20:06+00:00

PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt

url: refactor validateHostname

2019-03-27T16:05:17+00:00

This function did not only validate the input but it returned a new
value in case the hostname was valid. This simplifies the function
by always returning the required value, no matter if it is valid or
invalid, so the callee site does not have to check that anymore. On
top the function is renamed to `getHostname` to make clear that the
function does not only validate the input but it also returns a new
value.

PR-URL: https://github.com/nodejs/node/pull/26809
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

lib: use Array#includes instead of Array#indexOf

2019-03-21T13:38:02+00:00

PR-URL: https://github.com/nodejs/node/pull/26732
Refs: https://github.com/nodejs/node/issues/26568
Reviewed-By: Michaël Zasso 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca

lib: make lowerProto scope more clear

2019-03-15T09:23:15+00:00

PR-URL: https://github.com/nodejs/node/pull/26562
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca

url: require encodeStr from internal/querystring

2019-03-12T05:48:27+00:00

PR-URL: https://github.com/nodejs/node/pull/26538
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso