delta/node-new.git/lib/string_decoder.js, branch pull-request-doc-updates

bootstrapper: move internalBinding to NativeModule

2018-10-04T09:55:34+00:00

internalBinding is used so often that it should just automatically be
available for usage in internals.

PR-URL: https://github.com/nodejs/node/pull/23025
Refs: https://github.com/nodejs/node/commit/2a9eb31
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat

string_decoder: support typed array or data view

2018-09-17T15:48:44+00:00

Refs: https://github.com/nodejs/node/issues/1826
PR-URL: https://github.com/nodejs/node/pull/22562
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25T00:45:37+00:00

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: put bootstrappers in lib/internal/bootstrap/

2018-03-15T12:50:34+00:00

Create `lib/internal/bootstrap/` and put bootstrappers there:

Before:

```
lib/internal
├── ...
├── bootstrap_loaders.js
└── bootstrap_node.js
```

After:

```
lib/internal
├── ...
└── bootstrap
    ├── loaders.js
    └── node.js
```

PR-URL: https://github.com/nodejs/node/pull/19177
Refs: https://github.com/nodejs/node/pull/19112
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum

src: move internal loaders out of bootstrap_node.js

2018-03-06T14:12:46+00:00

- Moves the creation of `process.binding()`, `process._linkedBinding()`
  `internalBinding()` and `NativeModule` into a separate file
  `lib/internal/bootstrap_loaders.js`, and documents them there.
  This file will be compiled and run before `bootstrap_node.js`, which
  means we now bootstrap the internal module & binding system before
  actually bootstrapping Node.js.
- Rename the special ID that can be used to require `NativeModule`
  as `internal/bootstrap_loaders` since it is setup there. Also put
  `internalBinding` in the object exported by `NativeModule.require`
  instead of putting it inside the `NativeModule.wrapper`
- Use the original `getBinding()` to get the source code of native
  modules instead of getting it from `process.binding('native')`
  so that users cannot fake native modules by modifying the binding
  object.
- Names the bootstrapping functions so their names show up
  in the stack trace.

PR-URL: https://github.com/nodejs/node/pull/19112
Reviewed-By: Anna Henningsen 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

lib: port errors to new system

2018-03-05T18:51:30+00:00

This is a first batch of updates that touches non-underscored modules in
lib.

PR-URL: https://github.com/nodejs/node/pull/19034
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

lib: improve normalize encoding performance

2018-03-02T02:09:25+00:00

This focuses on the common case by making sure they are prioritized.
It also changes some typeof checks to test for undefined since
that is faster and it adds a benchmark.

PR-URL: https://github.com/nodejs/node/pull/18790
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina

string_decoder: fix regressions

2018-02-13T13:03:23+00:00

There are libraries which invoke StringDecoder using .call and
.inherits, which directly conflicts with making StringDecoder
be a class which can only be invoked with the new keyword.
Revert to declaring it as a function.

StringDecoder#lastNeed was not defined, redefine it using
the new interface and fix StringDecoder#lastTotal.

PR-URL: https://github.com/nodejs/node/pull/18723
Refs: https://github.com/nodejs/node/pull/18537
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Evan Lucas 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tiancheng "Timothy" Gu

string_decoder: reimplement in C++

2018-02-10T13:38:56+00:00

Implement string decoder in C++. The perks are a decent speed boost
(for decoding, whereas creation show some performance degradation),
that this can now be used more easily to add native decoding support
to C++ streams and (arguably) more readable variable names.

PR-URL: https://github.com/nodejs/node/pull/18537
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

string_decoder: reset decoder on end

2018-02-02T19:31:39+00:00

This resets the StringDecoder's state after calling `#end`. Further
writes to the decoder will act as if it were a brand new instance,
allowing simple reuse.

PR-URL: https://github.com/nodejs/node/pull/18494
Fixes: https://github.com/nodejs/node/issues/16564
Refs: https://github.com/nodejs/node/pull/16594
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen