delta/node-new.git/lib/querystring.js, branch pull-request-doc-updates

querystring: remove eslint-disable

2018-12-14T18:13:43+00:00

Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: https://github.com/nodejs/node/pull/24995
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anto Aravinth

lib: move encodeStr function to internal for reusable

2018-11-21T02:24:02+00:00

PR-URL: https://github.com/nodejs/node/pull/24242
Reviewed-By: James M Snell

querystring: remove unused catch bindings

2018-11-06T15:59:09+00:00

PR-URL: https://github.com/nodejs/node/pull/24079
Reviewed-By: Sam Roberts 
Reviewed-By: Wyatt Preul

lib: remove unused 'e' from catch

2018-10-13T16:33:07+00:00

PR-URL: https://github.com/nodejs/node/pull/23458
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Hitesh Kanwathirtha 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

tools: add 'spaced-comment' into eslint rules

2018-04-01T14:33:13+00:00

PR-URL: https://github.com/nodejs/node/pull/19596
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Sakthipriyan Vairamani

lib: port errors to new system

2018-03-05T18:51:30+00:00

This is a first batch of updates that touches non-underscored modules in
lib.

PR-URL: https://github.com/nodejs/node/pull/19034
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

querystring: convert to using internal/errors

2017-10-28T18:04:53+00:00

PR-URL: https://github.com/nodejs/node/pull/15565
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Gireesh Punathil

tools: enable additional eslint rules

2017-10-19T17:54:14+00:00

Enable additional rules that node either already adheres to
or it makes sense to do so going forward: for-direction,
accessor-pairs, no-lonely-if and symbol-description.

Fix all instances of no-lonely-if in lib & test and disable
accessor-pairs in test-util-inspect.

PR-URL: https://github.com/nodejs/node/pull/16243
Refs: https://eslint.org/docs/rules/for-direction
Refs: https://eslint.org/docs/rules/accessor-pairs
Refs: https://eslint.org/docs/rules/no-lonely-if
Refs: https://eslint.org/docs/rules/symbol-description
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig

querystring: avoid indexOf when parsing

2017-08-09T18:03:48+00:00

Fixes a performance regression in body-parser with V8 6.0.
Removes the use of an auxiliary array, and just query the object
directly.

PR-URL: https://github.com/nodejs/node/pull/14703
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Evan Lucas 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Luigi Pinca

querystring: fix up lastPos usage

2017-07-12T04:12:48+00:00

Use lastPos ONLY for tracking what has been .slice()'d, never as an
indication of if key/value has been seen, since lastPos is updated on
seeing + as well.

PR-URL: https://github.com/nodejs/node/pull/14151
Fixes: https://github.com/nodejs/node/issues/13773
Reviewed-By: James M Snell 
Reviewed-By: Brian White