delta/node-new.git/lib/querystring.js, branch devsnek-patch-1

querystring: reduce memory usage by Int8Array

2020-11-10T20:22:08+00:00

PR-URL: https://github.com/nodejs/node/pull/34179
Reviewed-By: Anna Henningsen 
Reviewed-By: Denys Otrishko 
Reviewed-By: Antoine du Hamel

tools: add new ESLint rule: prefer-primordials

2020-11-07T10:28:14+00:00

I added a new custom ESLint rule to fix these problems.

We have a lot of replaceable codes with primordials.
Accessing built-in objects is restricted by existing rule
(no-restricted-globals), but accessing property in the built-in objects
is not restricted right now. We manually review codes that can be
replaced by primordials, but there's a lot of code that actually needs
to be fixed. We have often made pull requests to replace the primordials
with.

Restrict accessing global built-in objects such as `Promise`.
Restrict calling static methods such as `Array.from` or `Symbol.for`.
Don't restrict prototype methods to prevent false-positive.

PR-URL: https://github.com/nodejs/node/pull/35448
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Ben Coe

lib: replace String global with primordials

2020-10-04T07:40:56+00:00

PR-URL: https://github.com/nodejs/node/pull/35397
Reviewed-By: Luigi Pinca 
Reviewed-By: Jiawen Geng 
Reviewed-By: Pranshu Srivastava 
Reviewed-By: Rich Trott 
Reviewed-By: Anto Aravinth 
Reviewed-By: Ujjwal Sharma

querystring: manage percent character at unescape

2020-09-04T03:43:39+00:00

Related: https://github.com/nodejs/node/issues/33892
Fixes: https://github.com/nodejs/node/issues/35012

PR-URL: https://github.com/nodejs/node/pull/35013
Reviewed-By: Joyee Cheung 
Reviewed-By: Shingo Inoue 
Reviewed-By: Rich Trott

lib: replace http to https of comment link urls

2020-07-06T14:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell

querystring: fix stringify for empty array

2020-06-24T23:18:00+00:00

PR-URL: https://github.com/nodejs/node/pull/33918
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

querystring: improve stringify() performance

2020-06-12T22:21:44+00:00

PR-URL: https://github.com/nodejs/node/pull/33669
Reviewed-By: Benjamin Gruenbaum

lib: enforce use of Array from primordials

2019-11-27T18:29:01+00:00

PR-URL: https://github.com/nodejs/node/pull/30635
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

querystring: replace var with let/const

2019-11-18T11:57:39+00:00

PR-URL: https://github.com/nodejs/node/pull/30429
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat