delta/node-new.git/lib/path.js, branch pull-request-doc-updates

path: replace assertPath() with validator

2018-12-07T03:57:11+00:00

The path module's assertPath() does exactly what the
validateString() validator does, so this commit updates
path to use validateString() instead. A couple drive by
updates to validateString() outside of assertPath() are
also included.

PR-URL: https://github.com/nodejs/node/pull/24840
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Jeremiah Senkpiel

lib: remove useless cwd in posix.resolve

2018-10-30T04:23:52+00:00

PR-URL: https://github.com/nodejs/node/pull/23902
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell

path: remove unnecessary if statement

2018-09-16T08:00:36+00:00

There is an `if`-statement in `normalizeString` (a helper function for
`path.normalize`) whose `else`-branch is never taken. This patch
removes it.

PR-URL: https://github.com/nodejs/node/pull/22273
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25T00:45:37+00:00

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

path: fix regression in posix.normalize

2018-03-23T18:47:11+00:00

Fixes a regression introduced in [1].
The posix version of normalize should not treat backslash as a path
separator.

[1] https://github.com/nodejs/node/commit/4ae320f2

PR-URL: https://github.com/nodejs/node/pull/19520
Fixes: https://github.com/nodejs/node/issues/19519
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

path: remove redundant function

2018-03-14T14:04:00+00:00

PR-URL: https://github.com/nodejs/node/pull/19237
Reviewed-By: Weijia Wang 
Reviewed-By: Michaël Zasso

lib: port errors to new system

2018-03-05T18:51:30+00:00

This is a first batch of updates that touches non-underscored modules in
lib.

PR-URL: https://github.com/nodejs/node/pull/19034
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

path: replace duplicate conditions by functions

2018-02-17T13:53:58+00:00

It will also remove useless "code" variables by inlining
path.charCodeAt.

PR-URL: https://github.com/nodejs/node/pull/18693
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jon Moss 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

path: replace "magic" numbers by readable constants

2018-02-12T19:12:40+00:00

PR-URL: https://github.com/nodejs/node/pull/18654
Reviewed-By: Richard Lau 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Kyle Farnung 
Reviewed-By: Jeremiah Senkpiel

path: fix path.normalize for relative paths

2018-01-11T03:11:22+00:00

After slicing, the `lastSegmentLength` should be calculated again,
instead of assigning value `j`.

PR-URL: https://github.com/nodejs/node/pull/17974
Fixes: https://github.com/nodejs/node/issues/17928
Reviewed-By: Michaël Zasso 
Reviewed-By: Gibson Fahnestock