delta/node-new.git/lib/path.js, branch devsnek-patch-1

path: fix comment grammar

2020-04-28T17:10:26+00:00

PR-URL: https://github.com/nodejs/node/pull/32942
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan

path: replace var with let in lib/path.js

2019-11-09T16:44:29+00:00

PR-URL: https://github.com/nodejs/node/pull/30260
Refs: https://github.com/nodejs/code-and-learn/issues/97
Reviewed-By: Ruben Bridgewater 
Reviewed-By: David Carlier 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Сковорода Никита Андреевич

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05T20:59:32+00:00

PR-URL: https://github.com/nodejs/node/pull/29834
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

path: improve normalization performance

2019-08-05T11:17:32+00:00

PR-URL: https://github.com/nodejs/node/pull/28948
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Gus Caplan

path: move branch to the correct location

2019-07-14T02:47:10+00:00

This code branch only makes sense when i === length. Otherwise it'll
already be handled.

PR-URL: https://github.com/nodejs/node/pull/28556
Fixes: https://github.com/nodejs/node/issues/28549
Reviewed-By: Rich Trott 
Reviewed-By: Weijia Wang 
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng 
Reviewed-By: Yongsheng Zhang

path: using .relative() should not return a trailing slash

2019-07-14T02:46:53+00:00

Resolving a path against root with `path.relative()` should not
include a trailing slash.

Fixes: https://github.com/nodejs/node/issues/28549

PR-URL: https://github.com/nodejs/node/pull/28556
Reviewed-By: Rich Trott 
Reviewed-By: Weijia Wang 
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng 
Reviewed-By: Yongsheng Zhang

path: simplify normalizeString

2019-04-18T03:32:10+00:00

This improves the `path.normalize()` and `path.resolve()` performance a
tiny bit.
One statement could never be truthy, another check could be simplified
and `code` is now monomorphic.

PR-URL: https://github.com/nodejs/node/pull/27240
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Luigi Pinca

path: refactor for less indentation

2019-04-03T00:35:18+00:00

This just switches the statements in a way that it reduces the
overall indentation. The function has a very deep indentation in
general and this should improve the readability.

PR-URL: https://github.com/nodejs/node/pull/26917
Reviewed-By: Michaël Zasso 
Reviewed-By: Matteo Collina

benchmark,lib: change var to const

2019-03-30T12:16:39+00:00

Refs: https://github.com/nodejs/node/pull/26679

PR-URL: https://github.com/nodejs/node/pull/26915
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann

path: remove dead code

2019-03-29T12:11:21+00:00

A couple of code parts could not be reached due to resolving the path
in the beginning. That "normalizes" the path in a way that some code
branches became obsolete.

PR-URL: https://github.com/nodejs/node/pull/26916
Reviewed-By: Sam Roberts 
Reviewed-By: Michaël Zasso