delta/node-new.git/lib/net.js, branch try_Python3_on_macOS

net: allow reading data into a static buffer

2019-08-23T21:05:52+00:00

Co-Authored-By: Anna Henningsen 

PR-URL: https://github.com/nodejs/node/pull/25436
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Ben Noordhuis

net: use callback to properly propagate error

2019-08-20T02:11:12+00:00

The socket will be destroyed upstream through the proper error
flow.

PR-URL: https://github.com/nodejs/node/pull/29178
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

net: shallow copy option when create Server

2019-08-04T04:58:03+00:00

PR-URL: https://github.com/nodejs/node/pull/28924
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Masashi Hirano 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Rich Trott

net: replace _writableState.finished with writableFinished

2019-06-26T15:14:32+00:00

Replace usage of quasi-private _writableState.finished with public
writableFinished property.

PR-URL: https://github.com/nodejs/node/pull/27974
Refs: https://github.com/nodejs/node/issues/445
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca

net: make writeAfterFIN() return false

2019-06-04T04:02:58+00:00

If `false` is not returned a readable stream piped into the socket
might continue reading indefinitely until the process goes out of
memory.

PR-URL: https://github.com/nodejs/node/pull/27996
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: move guessHandleType in the util binding

2019-04-20T05:25:41+00:00

It does not make too much sense to have modules unrelated to TTY
load the TTY binding just to use this method. Put this in the
util binding instead.

PR-URL: https://github.com/nodejs/node/pull/27289
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig

lib: require globals instead of using the global proxy

2019-04-15T20:24:26+00:00

In addition, use process.stderr instead of console.error when
there is no need to swallow the error.

PR-URL: https://github.com/nodejs/node/pull/27112
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

net: inline maybeDestroy()

2019-04-11T05:53:30+00:00

`maybeDestroy()` is only called from the listener of the `'end'` event.
That event is only emitted after the socket is connected (after `UV_EOF`
is read) and after `socket.readable` is set to `false`.

PR-URL: https://github.com/nodejs/node/pull/27136
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

lib: move DEP0021 to end of life

2019-04-10T12:25:50+00:00

Server.listenFD() has been runtime deprecated since
Node 0.7.12. This commit moves the deprecation to
end-of-life.

PR-URL: https://github.com/nodejs/node/pull/27127
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung