delta/node-new.git/lib/internal/source_map/source_map.js, branch devsnek-patch-1

lib: replace http to https of comment link urls

2020-07-06T14:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell

tools: enable no-else-return lint rule

2020-05-16T04:42:16+00:00

Refs: https://github.com/nodejs/node/pull/32644
Refs: https://github.com/nodejs/node/pull/32662

PR-URL: https://github.com/nodejs/node/pull/32667
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

lib: replace Array to ArrayIsArray by primordials

2020-03-30T08:22:52+00:00

PR-URL: https://github.com/nodejs/node/pull/32258
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat

module: port source map sort logic from chromium

2020-02-28T01:33:56+00:00

Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: #31286

PR-URL: https://github.com/nodejs/node/pull/31927
Fixes: https://github.com/nodejs/node/issues/31286
Reviewed-By: Joyee Cheung 
Reviewed-By: Rich Trott

lib: delete dead code in SourceMap

2020-01-28T15:29:33+00:00

This seems to be a leftover from the chromium project. Nothing uses
`#reverseMappingsBySourceURL`, so constructing it isn't necessary.

PR-URL: https://github.com/nodejs/node/pull/31512
Reviewed-By: Ben Coe 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

process: fix two overflow cases in SourceMap VLQ decoding

2020-01-27T01:03:39+00:00

These both have to do with extremely large numbers, so it's unlikely to
cause a problem in practice. Still, correctness.

First, encoding `-2147483648` in VLQ returns the value `"B"`. When
decoding, we get the value `1` after reading the base64. We then check
if the first bit is set (it is) to see if we should negate it, then we
shift all bits right once. Now, `value` will be `0` and `negate` will
be `true`. So, we'd return `-0`. Which is a bug! `-0` isn't
`-2147483648`, and we've broken a round trip.

Second, encoding any number with the 31st bit set, we'd return the
opposite sign. Let's use `1073741824`. Encoding, we get `"ggggggC"`.
When decoding, we get the value `-2147483648` after reading the base64.
Notice, it's already negative (the 32nd bit is set, because the 31st was
set and we shifted everything left once). We'd then check the first bit
(it's not) and shift right. But we used `>>`, which does not shift the
sign bit. We actually wanted `>>>`, which will. Because of that bug, we
get back `-1073741824` instead of the positive `1073741824`. It's even
worse if the 32nd and 31st bits are set, `-1610612736` becomes
`536870912` after a round trip.

I recently fixed the same two bugs in Closure Compiler:
https://github.com/google/closure-compiler/commit/584418eb

PR-URL: https://github.com/nodejs/node/pull/31490
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Coe 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Gus Caplan

module: add API for interacting with source maps

2020-01-14T20:39:06+00:00

PR-URL: https://github.com/nodejs/node/pull/31132
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell

process: add source-map support to stack traces

2019-10-06T00:08:00+00:00

PR-URL: https://github.com/nodejs/node/pull/29564
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell