delta/node-new.git/lib/internal/encoding.js, branch main

src: make AliasedBuffers in the binding data weak

2023-04-20T03:28:35+00:00

The binding data holds references to the AliasedBuffers directly
from their wrappers which already ensures that the AliasedBuffers
won't be accessed when the wrappers are GC'ed. So we can just
make the global references to the AliasedBuffers weak. This way
we can simply deserialize the typed arrays when deserialize the
binding data and avoid the extra Object::Set() calls. It also
eliminates the caveat in the JS land where aliased buffers must
be dynamically read from the binding.

PR-URL: https://github.com/nodejs/node/pull/47354
Refs: https://github.com/nodejs/node/issues/47353
Reviewed-By: Chengzhong Wu

src: use AliasedUint32Array for encodeInto results

2023-03-07T21:54:41+00:00

Getting the buffer from a TypedArray created from the JS land
incurs a copy. For encodeInto() results we can just use an
AliasedArray and let the binding always own the store.

PR-URL: https://github.com/nodejs/node/pull/46658
Reviewed-By: Darshan Sen

src: move encoding bindings to a new binding

2023-03-07T21:45:42+00:00

Move the bindings used by TextEncoder to a new binding for
more self-contained code.

PR-URL: https://github.com/nodejs/node/pull/46658
Reviewed-By: Darshan Sen

lib: add trailing commas to more internal files

2023-02-26T10:34:02+00:00


PR-URL: https://github.com/nodejs/node/pull/46811
Reviewed-By: Moshe Atlow 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

tools: add `prefer-proto` rule

2023-01-10T05:38:36+00:00

fixup: add support for `Object.create(null)`

fixup: extend to any 1-argument Object.create call

fixup: add tests
PR-URL: https://github.com/nodejs/node/pull/46083
Reviewed-By: Colin Ihrig 
Reviewed-By: Geoffrey Booth 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Jacob Smith 
Reviewed-By: Antoine du Hamel

util: add fast path for text-decoder fatal flag

2022-12-22T20:22:28+00:00

PR-URL: https://github.com/nodejs/node/pull/45803
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michael Dawson

lib: remove unnecessary lazy loading in `internal/encoding`

2022-12-12T15:17:53+00:00

PR-URL: https://github.com/nodejs/node/pull/45810
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Yagiz Nizipli

util: add fast path for utf8 encoding

2022-11-12T21:31:44+00:00

Co-authored-by: Anna Henningsen 
PR-URL: https://github.com/nodejs/node/pull/45412
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Santiago Gimeno

util: improve text decoder performance

2022-11-12T01:48:29+00:00

PR-URL: https://github.com/nodejs/node/pull/45388
Reviewed-By: Anna Henningsen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Rich Trott

util: improve text-decoder performance

2022-11-09T14:17:31+00:00

PR-URL: https://github.com/nodejs/node/pull/45363
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott