delta/node-new.git/lib/internal/cli_table.js, branch devsnek-patch-1

src: remove _third_party_main support

2020-06-24T22:20:59+00:00

Since 7dead8440c7ee, there is a more official alternative that is
tested and comes with a proper API, and since a6c57cc66d0, the
`LoadEnvironment(env)` overload is deprecated, which is the closest
thing we can achieve to deprecating `_third_party_main` support.

Thus, we can now consider us able to remove `_third_party_main`
support.

Fixes: https://github.com/nodejs/node/issues/24017
Refs: https://github.com/nodejs/node/pull/30467
Refs: https://github.com/nodejs/node/pull/32858

PR-URL: https://github.com/nodejs/node/pull/33971
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Michael Dawson

util: improve unicode support

2020-01-22T14:33:03+00:00

The array grouping function relies on the width of the characters.
It was not calculated correct so far, since it used the string
length instead.
This improves the unicode output by calculating the mono-spaced
font width (other fonts might differ).

PR-URL: https://github.com/nodejs/node/pull/31319
Reviewed-By: James M Snell 
Reviewed-By: Steven R Loomis 
Reviewed-By: Rich Trott 
Reviewed-By: Minwoo Jung

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

lib: replace var to let in cli_table.js

2019-11-24T04:44:47+00:00

PR-URL: https://github.com/nodejs/node/pull/30400
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

console: use getStringWidth() for character width calculation

2019-09-02T06:13:58+00:00

This is more accurate for displayed full-width characters
(e.g. CJK ones) and makes the calculations match the ones we
use in the readline module.

Fixes: https://github.com/nodejs/node/issues/29299

PR-URL: https://github.com/nodejs/node/pull/29300
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

lib: use safe methods from primordials

2019-04-08T09:23:09+00:00

This changes the primordials to expose built-in prototypes with their
methods already uncurried.
The uncurryThis function is therefore moved to the primordials.
All uses of uncurryThis on built-ins are changed to import the relevant
prototypes from primordials.
All uses of Function.call.bind are also changed to use primordials.

PR-URL: https://github.com/nodejs/node/pull/27096
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

lib: force using primordials for JSON, Math and Reflect

2019-04-03T13:36:08+00:00

Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: https://github.com/nodejs/node/pull/27027
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca

lib,test: remove lib/internal/test/unicode.js

2019-01-03T18:25:59+00:00

Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.

PR-URL: https://github.com/nodejs/node/pull/25298
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

lib: refactor cli table

2018-07-14T12:04:38+00:00

The cli table used multi line template strings which are normally
not used in our code base and it also upper cased a regular function
name. This is changed by this patch.

PR-URL: https://github.com/nodejs/node/pull/20960
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Michaël Zasso

console: add table method

2018-03-31T00:41:41+00:00

PR-URL: https://github.com/nodejs/node/pull/18137
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ruben Bridgewater