delta/node-new.git/lib/internal/assert, branch devsnek-patch-1

assert: refactor to use more primordials

2020-11-13T21:59:55+00:00

PR-URL: https://github.com/nodejs/node/pull/35998
Reviewed-By: Rich Trott

lib: use primordials when calling methods of Error

2020-10-30T11:08:20+00:00

This is to unsure that code using those methods won't crash if the
methods are deleted in userland.

PR-URL: https://github.com/nodejs/node/pull/35837
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Shingo Inoue

lib: replace String global with primordials

2020-10-04T07:40:56+00:00

PR-URL: https://github.com/nodejs/node/pull/35397
Reviewed-By: Luigi Pinca 
Reviewed-By: Jiawen Geng 
Reviewed-By: Pranshu Srivastava 
Reviewed-By: Rich Trott 
Reviewed-By: Anto Aravinth 
Reviewed-By: Ujjwal Sharma

assert: port common.mustCall() to assert

2020-04-23T17:11:47+00:00

Fixes: https://github.com/nodejs/node/issues/31392

PR-URL: https://github.com/nodejs/node/pull/31982
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko

assert: align character indicators properly

2020-02-09T12:39:54+00:00

This makes sure color codes are not taken into account in case
util.inspect's default value was changed.

PR-URL: https://github.com/nodejs/node/pull/31429
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen

lib: replace use of Error with primordials

2020-01-04T22:50:18+00:00

PR-URL: https://github.com/nodejs/node/pull/31163
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

lib: introduce no-mixed-operators eslint rule to lib

2019-10-05T20:59:32+00:00

PR-URL: https://github.com/nodejs/node/pull/29834
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

assert: avoid potentially misleading reference to object identity

2019-07-26T05:36:29+00:00

Often, the word “identical” when referring to JS objects will
be read as referring to having the same object identity (which is
called “reference equality” here), but what the error message is
trying to say here is that the objects are different but yield the
same `util.inspect()` output.

Since `util.inspect()` output represents the structure rather than
the identity of objects, (hopefully) clarify the error message to
reflect that.

PR-URL: https://github.com/nodejs/node/pull/28824
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

assert: print more lines in the error diff

2019-06-13T02:50:03+00:00

So far consequitive identical lines were collapsed if there were at
least three. Now they are only collapsed from five identical lines on.

This also simplifies the implementation a tiny bit by abstracting some
logic.

PR-URL: https://github.com/nodejs/node/pull/28058
Reviewed-By: Rich Trott