delta/node-new.git/lib/internal/assert.js, branch main

benchmark,doc,lib,test: prepare for padding lint rule

2019-11-30T14:28:29+00:00

Upcoming lint rule will require a blank line between consecutive
functions. Add it in the places where we don't have it already.

PR-URL: https://github.com/nodejs/node/pull/30696
Reviewed-By: Michaël Zasso 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Luigi Pinca

lib: throw a special error in internal/assert

2019-04-24T23:29:48+00:00

Instead of using the public AssertionError, use a simplified
error that describes potential causes of these assertions
and suggests the user to open an issue.

PR-URL: https://github.com/nodejs/node/pull/26635
Reviewed-By: Ruben Bridgewater

assert: add internal assert.fail()

2019-02-13T23:00:50+00:00

PR-URL: https://github.com/nodejs/node/pull/26047
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell

assert: create internal/assert micro-module

2019-02-08T08:01:09+00:00

For use in built-in modules that could benefit from `assert()` without
having to load the entire module (unless an AssertionError actually
occurs): lib/internal/assert.js.

PR-URL: https://github.com/nodejs/node/pull/25956
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Minwoo Jung

assert: refactor internal assert.js

2019-02-08T08:01:07+00:00

Move lib/internal/assert.js to lib/internal/assert/assertion_error.js.
This is in preparation for making lib/internal/assert.js a tiny module
for use in Node.js built-ins so that we can use `assert()` without
having to load the entire ~1200 line `assert` module.

PR-URL: https://github.com/nodejs/node/pull/25956
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Minwoo Jung

assert: make `actual` and `expected` getters

2019-01-10T02:26:50+00:00

The `actual` and `expected` properties on an instance of
`AssertionError` is now a getter to prevent inspecting these when
inspecting the error. These values will be visible in the error
message and showing them otherwise would decrease the readability
of the error.

PR-URL: https://github.com/nodejs/node/pull/25250
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

assert: inspect getters

2018-12-18T11:34:08+00:00

While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.

PR-URL: https://github.com/nodejs/node/pull/25004
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso

assert: remove internal errorCache property

2018-10-09T13:39:46+00:00

The internal assert module exposed an errorCache property solely for
testing. It is no longer necessary. Remove it.

PR-URL: https://github.com/nodejs/node/pull/23304
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani

assert: add comments for diff algorithm

2018-09-27T11:36:24+00:00

It became hard to follow what was actually happening in the
algorithm. This adds comments to improve the situation.

PR-URL: https://github.com/nodejs/node/pull/23048
Refs: https://github.com/nodejs/node/issues/22763
Reviewed-By: Anna Henningsen 
Reviewed-By: Shingo Inoue 
Reviewed-By: James M Snell

assert: reduce diff noise

2018-09-27T11:36:23+00:00

Assertion errors that produce a diff show a diff for identical entries
in case one side of the comparison has more object properties than the
other one. Those lines are now taken into account and will not show up
as diverging lines anymore.

Refs: https://github.com/nodejs/node/issues/22763

PR-URL: https://github.com/nodejs/node/pull/23048
Refs: https://github.com/nodejs/node/issues/22763
Reviewed-By: Anna Henningsen 
Reviewed-By: Shingo Inoue 
Reviewed-By: James M Snell