delta/node-new.git/lib/https.js, branch sam-github-tsc

lib: improve debuglog() performance

2020-05-30T21:24:43+00:00

PR-URL: https://github.com/nodejs/node/pull/32260
Reviewed-By: James M Snell

https: prevent options object from being mutated

2020-01-04T04:09:27+00:00

Previously, when passing options object to the agent.createConnection
method, the same options object got modified within the method. Now,
any modification will happen on only a copy of the object.

Fixes: https://github.com/nodejs/node/issues/31119

PR-URL: https://github.com/nodejs/node/pull/31151
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Anto Aravinth 
Reviewed-By: David Carlier 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

http,https: increase server headers timeout

2019-12-14T13:59:19+00:00

Fixes: https://github.com/nodejs/node/issues/24980
Refs: https://github.com/nodejs/node/commit/eb43bc04b1

PR-URL: https://github.com/nodejs/node/pull/30071
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

https: change var to let in lib/https.js

2019-11-08T23:27:20+00:00

Changed a variable declaration.

PR-URL: https://github.com/nodejs/node/pull/30320
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Jiawen Geng 
Reviewed-By: Gireesh Punathil

http, http2: remove default server timeout

2019-05-09T15:54:04+00:00

Timing out and closing the socket after two minutes have elapsed is
surprising and problematic for users. This behavior was specific to
Node.js, and doesn't seem to be common in other language runtimes.

Fixes: https://github.com/nodejs/node/issues/27556

PR-URL: https://github.com/nodejs/node/pull/27558
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

https: remove usage of public require('util')

2019-03-23T13:10:24+00:00

Use `require('internal/util/debuglog').debuglog`
and `Object.setPrototypeOf` instead of `require('util').debuglog`
and `require('util').inherits`.

Refs: https://github.com/nodejs/node/issues/26546

PR-URL: https://github.com/nodejs/node/pull/26772
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: James M Snell

tls: introduce client 'session' event

2019-02-02T03:06:58+00:00

OpenSSL has supported async notification of sessions and tickets since
1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using
the async API is optional for TLS1.2 and below, but for TLS1.3 it will
be mandatory. Future-proof applications should start to use async
notification immediately. In the future, for TLS1.3, applications that
don't use the async API will silently, but gracefully, fail to resume
sessions and instead do a full handshake.

See: https://wiki.openssl.org/index.php/TLS1.3#Sessions

PR-URL: https://github.com/nodejs/node/pull/25831
Reviewed-By: Anna Henningsen 
Reviewed-By: Fedor Indutny

lib: support overriding http\s.globalAgent

2019-01-07T23:10:36+00:00

Overriding `require('http[s]').globalAgent` is now respected by
consequent requests.

In order to achieve that, the following changes were made:

1. Implmentation in `http`: `module.exports.globalAgent` is now defined
through `Object.defineProperty`. Its getter and setter return \ set
`require('_http_agent').globalAgent`.

2. Implementation in `https`: the https `globalAgent` is not the same
as `_http_agent`, and is defined in `https` module itself. Therefore,
the fix here was to simply use `module.exports.globalAgent` to support
mutation.

3. According tests were added for both `http` and `https`, where in
both we create a server, set the default agent to a newly created
instance and make a request to that server. We then assert that the
given instance was actually used by inspecting its sockets property.

Fixes: https://github.com/nodejs/node/issues/23281

PR-URL: https://github.com/nodejs/node/pull/25170
Reviewed-By: James M Snell