delta/node-new.git/lib/https.js, branch devsnek-patch-1

https: set requestTimeout default to 0

2020-09-21T15:32:26+00:00

Fixes: https://github.com/nodejs/node/issues/35261

PR-URL: https://github.com/nodejs/node/pull/35264
Reviewed-By: Matteo Collina 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Beth Griggs 
Reviewed-By: Rich Trott

http: add requestTimeout

2020-09-15T19:39:54+00:00

This commits introduces a new http.Server option called requestTimeout
with a default value in milliseconds of 0.

If requestTimeout is set to a positive value, the server will start a new
timer set to expire in requestTimeout milliseconds when a new connection
is established. The timer is also set again if new requests after the
first are received on the socket (this handles pipelining and keep-alive
cases).
The timer is cancelled when:

1. the request body is completely received by the server.
2. the response is completed. This handles the case where the
application responds to the client without consuming the request body.
3. the connection is upgraded, like in the WebSocket case.

If the timer expires, then the server responds with status code 408 and
closes the connection.

CVE-2020-8251

PR-URL: https://github.com/nodejs-private/node-private/pull/208
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell 
Reviewed-By: Robert Nagy 
Reviewed-By: Mary Marchini 
Co-Authored-By: Paolo Insogna 
Co-Authored-By: Robert Nagy

lib: replace http to https of comment link urls

2020-07-06T14:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell

lib: improve debuglog() performance

2020-05-30T21:24:43+00:00

PR-URL: https://github.com/nodejs/node/pull/32260
Reviewed-By: James M Snell

https: prevent options object from being mutated

2020-01-04T04:09:27+00:00

Previously, when passing options object to the agent.createConnection
method, the same options object got modified within the method. Now,
any modification will happen on only a copy of the object.

Fixes: https://github.com/nodejs/node/issues/31119

PR-URL: https://github.com/nodejs/node/pull/31151
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Anto Aravinth 
Reviewed-By: David Carlier 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

http,https: increase server headers timeout

2019-12-14T13:59:19+00:00

Fixes: https://github.com/nodejs/node/issues/24980
Refs: https://github.com/nodejs/node/commit/eb43bc04b1

PR-URL: https://github.com/nodejs/node/pull/30071
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

https: change var to let in lib/https.js

2019-11-08T23:27:20+00:00

Changed a variable declaration.

PR-URL: https://github.com/nodejs/node/pull/30320
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Jiawen Geng 
Reviewed-By: Gireesh Punathil

http, http2: remove default server timeout

2019-05-09T15:54:04+00:00

Timing out and closing the socket after two minutes have elapsed is
surprising and problematic for users. This behavior was specific to
Node.js, and doesn't seem to be common in other language runtimes.

Fixes: https://github.com/nodejs/node/issues/27556

PR-URL: https://github.com/nodejs/node/pull/27558
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan