delta/node-new.git/lib/fs, branch sam-github-tsc

fs: add fs/promises alias module

2020-02-19T06:15:50+00:00

PR-URL: https://github.com/nodejs/node/pull/31553
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Myles Borins 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Yuta Hiroto

fs: move fs/promises to fs.promises

2018-05-07T23:47:42+00:00

PR-URL: https://github.com/nodejs/node/pull/20504
Refs: https://github.com/nodejs/TSC/issues/389
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Myles Borins 
Reviewed-By: Shingo Inoue 
Reviewed-By: Joyee Cheung 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ali Ijaz Sheikh

lib: introduce internal/validators

2018-04-26T17:42:48+00:00

Create a file to centralize argument validators that are used in
multiple internal modules.
Move validateInt32 and validateUint32 to this file.

PR-URL: https://github.com/nodejs/node/pull/19973
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

fs: handle long files reading in fs.promises

2018-04-16T01:10:49+00:00

PR-URL: https://github.com/nodejs/node/pull/19643
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ruben Bridgewater

errors: validate input arguments

2018-04-13T17:59:44+00:00

This makes sure the input arguments get validated so implementation
errors will be caught early. It also improves a couple of error
messages by providing more detailed information and fixes errors
detected by the new functionality. Besides that a error type got
simplified and tests got refactored.

PR-URL: https://github.com/nodejs/node/pull/19924
Reviewed-By: Michaël Zasso 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

fs: refactor stats array to be more generic

2018-04-04T07:25:59+00:00

- Pass kFsStatsFieldsLength between JS and C++ instead of using the
  magic number 14
- Pass the global stats array to the completion callback of
  asynchronous FSReqWrap similar to how the stats arrays are passed
  to the FSReqPromise resolvers
- Abstract the stats converter and take an offset to compute the
  old stats in fs.watchFile
- Use templates in node::FillStatsArray and FSReqPromise in preparation
  for BigInt intergration
- Put the global stat array filler in node_internals.h because it is
  shared by node_file.cc and node_stat_watcher.cc

PR-URL: https://github.com/nodejs/node/pull/19714
Reviewed-By: James M Snell

tools: add 'spaced-comment' into eslint rules

2018-04-01T14:33:13+00:00

PR-URL: https://github.com/nodejs/node/pull/19596
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Sakthipriyan Vairamani

lib,test: minor refactoring

2018-03-25T00:45:38+00:00

This refactors a couple tests to have upper case first characters
in comments and to use `input` instead of `i`.
It also adds a few TODOs and rewrites a few lines to use default
arguments and to prevent function recreation when unnecessary.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25T00:45:37+00:00

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

fs: use encoding in readFile

2018-03-24T17:23:08+00:00

Use the encoding parameter passed to fsPromises.readFile if it is
passed. Currently the encoding parameter is ignored in fsPromises.

PR-URL: https://github.com/nodejs/node/pull/19296
Fixes: https://github.com/nodejs/node/issues/19286
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Evan Lucas 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung 
Reviewed-By: Yuta Hiroto