delta/node-new.git/lib/console.js, branch Ninja.py-StringIO

console: split console into global.js and constructor.js

2018-12-01T20:51:18+00:00

Since we do not actually use the Console constructor to
instantiate the global console, move the two piece of
code into two different JS files for clarity, and make
console.js a mere re-export of the global console.
The hope is to make the global console, a namespace, more
web-compatible while keeping the Console constructor
available for backwards compatibility.

PR-URL: https://github.com/nodejs/node/pull/24709
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

lib: move lib/console.js to lib/internal/console/constructor.js

2018-12-01T20:51:17+00:00

This is a broken commit: it's here so that git interpret this
as a file move and preserve most of the history of the Console
constructor.

PR-URL: https://github.com/nodejs/node/pull/24709
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

console: lazy load process.stderr and process.stdout

2018-11-28T17:52:54+00:00

This patch:

- Refactors the Console constructor: moves the property binding code
  into and the writable streams binding code into two methods defined
  on the Console.prototype with symbols.
- Refactors the global console creation: we only need to share the
  property binding code from the Console constructor. To bind the
  streams we can lazy load `process.stdio` and `process.stderr`
  so that we don't create these streams when they are not used.
  This significantly reduces the number of modules loaded during
  bootstrap. Also, by calling the refactored-out method directly
  we can skip the unnecessary typechecks when creating the global
  console and there is no need to create a temporary Console
  anymore.
- Refactors the error handler creation and the `write` method:
  use a `kUseStdout` symbol to tell the internals which stream
  should be loaded from the console instance. Also put the
  `write` method on the Console prototype so it just loads
  other properties directly off the console instance which simplifies
  the call sites.

Also leaves a few TODOs for further refactoring of the console
bootstrap.

PR-URL: https://github.com/nodejs/node/pull/24534
Reviewed-By: Gus Caplan

console: improve code readability

2018-11-20T19:46:38+00:00

use object spread to make console code more readable

PR-URL: https://github.com/nodejs/node/pull/24412
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

console: console.timeLog() using the default label

2018-11-13T04:32:56+00:00

PR-URL: https://github.com/nodejs/node/pull/24286
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater

console: bind methods from the prototype chain in Console

2018-11-06T04:53:59+00:00

In 62232361 we made the console.Console function construct an object
with methods from Console.prototype bound to the instance, instead of
with methods found on the prototype chain to be bound on the instances,
thus breaking users overriding these methods when subclassing Console
because they are not expecting this function to construct a
namespace whose methods are not looked up from the prototype
chain.

This patch restores the previous behavior since it does not affect
the characteristics of the global console anyway. So after this patch,
the Console function still constructs normal objects with function
properties looked up from the prototype chain but bound to the
instances always.

PR-URL: https://github.com/nodejs/node/pull/24047
Reviewed-By: John-David Dalton 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig

lib: make the global console [[Prototype]] an empty object

2018-10-26T03:33:43+00:00

From the WHATWG console spec:

> For historical web-compatibility reasons, the namespace object for
> console must have as its [[Prototype]] an empty object, created as
> if by ObjectCreate(%ObjectPrototype%), instead of %ObjectPrototype%.

Since in Node.js, the Console constructor has been exposed through
require('console'), we need to keep the Console constructor but
we cannot actually use `new Console` to construct the global console.

This patch changes the prototype chain of the global console object,
so the console.Console.prototype is not in the global console prototype
chain anymore.

```
const proto = Object.getPrototypeOf(global.console);
// Before this patch
proto.constructor === global.console.Console
// After this patch
proto.constructor === Object
```

But, we still maintain that

```
global.console instanceof global.console.Console
```

through a custom Symbol.hasInstance function of Console that tests
for a special symbol kIsConsole for backwards compatibility.

This fixes a case in the console Web Platform Test that we commented
out.

PR-URL: https://github.com/nodejs/node/pull/23509
Refs: https://github.com/whatwg/console/issues/3
Refs: https://console.spec.whatwg.org/#console-namespace
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: John-David Dalton

console: add trace-events for time and count

2018-10-18T22:00:29+00:00

Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: https://github.com/nodejs/node/pull/23703
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau

bootstrapper: move internalBinding to NativeModule

2018-10-04T09:55:34+00:00

internalBinding is used so often that it should just automatically be
available for usage in internals.

PR-URL: https://github.com/nodejs/node/pull/23025
Refs: https://github.com/nodejs/node/commit/2a9eb31
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat

lib: change abstract equal to strict equal

2018-09-27T03:30:34+00:00

PR-URL: https://github.com/nodejs/node/pull/22974
Reviewed-By: Anna Henningsen 
Reviewed-By: John-David Dalton 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat