delta/node-new.git/lib/buffer.js, branch docs-fix

src: reset zero fill toggle at pre-execution

2020-07-18T03:23:16+00:00

The connection between the JS land zero fill toggle and the
C++ one in the NodeArrayBufferAllocator gets lost if the toggle
is deserialized from the snapshot, because V8 owns the underlying
memory of this toggle. This resets the connection at pre-execution.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

worker: add public method for marking objects as untransferable

2020-06-25T15:33:29+00:00

We currently mark a number of `ArrayBuffer`s as not transferable,
including the `Buffer` pool and ones with finalizers provided
by C++ addons.

There is no good reason to assume that userland code might not
encounter similar problems, for example when doing `ArrayBuffer`
pooling similar to ours. Therefore, provide an API that lets
userland code also mark objects as not transferable.

PR-URL: https://github.com/nodejs/node/pull/33979
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

buffer: remove hoisted variable

2020-05-23T18:47:02+00:00

PR-URL: https://github.com/nodejs/node/pull/33470
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Ruben Bridgewater

buffer: improve copy() performance

2020-05-09T06:04:10+00:00

There is no need to create a slice when sourceEnd is out of bounds.

PR-URL: https://github.com/nodejs/node/pull/33214
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Zeyu Yang 
Reviewed-By: Luigi Pinca

buffer: add type check in bidirectionalIndexOf

2020-04-13T21:22:09+00:00

Add a type check in bidirectionalIndexOf to avoid using something else
as Buffer. This may happen if e.g. lastIndexOf is called with invalid
this.

PR-URL: https://github.com/nodejs/node/pull/32770
Fixes: https://github.com/nodejs/node/issues/32753
Fixes: https://github.com/nodejs/node/issues/32747
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yongsheng Zhang

buffer: mark pool ArrayBuffer as untransferable

2020-04-13T16:47:27+00:00

This removes a footgun in which users could attempt to transfer the
pooled ArrayBuffer underlying a regular `Buffer`, which would lead to
all `Buffer`s that share the same pool being rendered unusable as well,
and potentially break creation of new pooled `Buffer`s.

This disables this kind of transfer.

Refs: https://github.com/nodejs/node/issues/32752

PR-URL: https://github.com/nodejs/node/pull/32759
Reviewed-By: Ben Noordhuis 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell

buffer: improve from() performance

2020-02-09T02:40:49+00:00

PR-URL: https://github.com/nodejs/node/pull/31615
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

buffer: improve concat() performance

2020-01-29T03:57:20+00:00

PR-URL: https://github.com/nodejs/node/pull/31522
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

buffer: improve fill(number) performance

2020-01-27T00:16:05+00:00

PR-URL: https://github.com/nodejs/node/pull/31489
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater

lib: replace use of Error with primordials

2020-01-04T22:50:18+00:00

PR-URL: https://github.com/nodejs/node/pull/31163
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat