delta/node-new.git/lib/buffer.js, branch devsnek-patch-1

lib: use remaining typed arrays from primordials

2020-10-07T13:44:21+00:00

PR-URL: https://github.com/nodejs/node/pull/35499
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Shingo Inoue

buffer: adjust validation to account for buffer.kMaxLength

2020-09-12T11:17:59+00:00

PR-URL: https://github.com/nodejs/node/pull/35134
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Yongsheng Zhang

lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_ENCODING

2020-09-11T14:54:42+00:00

This will be a start to generalize all argument validation
errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more
specific errors.
The OPT errors didn't bring much to the errors as it's just another
variant of ARG error which is sometimes more confusing (some of our code
used OPT errors to denote just argument validation errors presumably
because of similarity of OPT to 'option' and not 'options-object')
and they don't specify the name of the options object where the invalid
value is located. Much better approach would be to just specify path
to the invalid value in the name of the value as it is done in this PR
(i.e. 'options.format', 'options.publicKey.type' etc)

Also since this decreases a variety of errors we have it'd be easier to
reuse validation code across the codebase.

Refs: https://github.com/nodejs/node/pull/31251
Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009
Signed-off-by: Denys Otrishko 

PR-URL: https://github.com/nodejs/node/pull/34682
Reviewed-By: Matteo Collina 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: reset zero fill toggle at pre-execution

2020-07-18T03:23:16+00:00

The connection between the JS land zero fill toggle and the
C++ one in the NodeArrayBufferAllocator gets lost if the toggle
is deserialized from the snapshot, because V8 owns the underlying
memory of this toggle. This resets the connection at pre-execution.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

worker: add public method for marking objects as untransferable

2020-06-25T15:33:29+00:00

We currently mark a number of `ArrayBuffer`s as not transferable,
including the `Buffer` pool and ones with finalizers provided
by C++ addons.

There is no good reason to assume that userland code might not
encounter similar problems, for example when doing `ArrayBuffer`
pooling similar to ours. Therefore, provide an API that lets
userland code also mark objects as not transferable.

PR-URL: https://github.com/nodejs/node/pull/33979
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

buffer: remove hoisted variable

2020-05-23T18:47:02+00:00

PR-URL: https://github.com/nodejs/node/pull/33470
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Ruben Bridgewater

buffer: improve copy() performance

2020-05-09T06:04:10+00:00

There is no need to create a slice when sourceEnd is out of bounds.

PR-URL: https://github.com/nodejs/node/pull/33214
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Zeyu Yang 
Reviewed-By: Luigi Pinca

buffer: add type check in bidirectionalIndexOf

2020-04-13T21:22:09+00:00

Add a type check in bidirectionalIndexOf to avoid using something else
as Buffer. This may happen if e.g. lastIndexOf is called with invalid
this.

PR-URL: https://github.com/nodejs/node/pull/32770
Fixes: https://github.com/nodejs/node/issues/32753
Fixes: https://github.com/nodejs/node/issues/32747
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Yongsheng Zhang

buffer: mark pool ArrayBuffer as untransferable

2020-04-13T16:47:27+00:00

This removes a footgun in which users could attempt to transfer the
pooled ArrayBuffer underlying a regular `Buffer`, which would lead to
all `Buffer`s that share the same pool being rendered unusable as well,
and potentially break creation of new pooled `Buffer`s.

This disables this kind of transfer.

Refs: https://github.com/nodejs/node/issues/32752

PR-URL: https://github.com/nodejs/node/pull/32759
Reviewed-By: Ben Noordhuis 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell

buffer: improve from() performance

2020-02-09T02:40:49+00:00

PR-URL: https://github.com/nodejs/node/pull/31615
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen