delta/node-new.git/lib/async_hooks.js, branch Ninja.py-StringIO

process: improve queueMicrotask performance

2019-06-10T05:49:40+00:00

Optimize the hot code paths of queueMicrotask by
not creating unnecessary objects, not looking up
properties on frozen primordials, etc.

PR-URL: https://github.com/nodejs/node/pull/28093
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina

async_hooks: improve AsyncResource performance

2019-04-05T03:37:01+00:00

Accessing symbols is generally quite expensive and so is emitInit,
only do both when actually required.

PR-URL: https://github.com/nodejs/node/pull/27032
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

lib: force using primordials for JSON, Math and Reflect

2019-04-03T13:36:08+00:00

Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: https://github.com/nodejs/node/pull/27027
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca

async_hooks: remove deprecated emitBefore and emitAfter

2019-03-18T10:36:48+00:00

AsyncResource.emitBefore and AsyncResource.emitAfter have been
deprecated in https://github.com/nodejs/node/pull/18632. This PR removes
it all.
This commit also updates some embedder tests to use internal APIs.
The conditions are still possible for Node.js core developers but not
for end users.

PR-URL: https://github.com/nodejs/node/pull/26530
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Benedikt Meurer 
Reviewed-By: Yang Guo 
Reviewed-By: Andreas Madsen 
Reviewed-By: James M Snell

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

lib: extract validateString validator

2018-08-07T14:51:27+00:00

Pulls out a common argument validator to `internal/validators`

PR-URL: https://github.com/nodejs/node/pull/22101
Reviewed-By: Joyee Cheung 
Reviewed-By: Michaël Zasso 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25T00:45:37+00:00

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

async_hooks: remove async_wrap from async_hooks.js

2018-03-18T11:08:38+00:00

This commit removes the builtin async_wrap module from
lib/async_hooks.js.

The motivation for this is that lib/async_hooks.js requires
lib/internal/async_hooks which also binds async_wrap. Instead of
lib/async_hooks.js also binding async_wrap it now only has to require
the internal async_hooks and access it's exports.

There might be a very good reason for doing it the current way but the
reason is not obvious to me. Hopefully someone can shed some light on
this.

PR-URL: https://github.com/nodejs/node/pull/19368
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Andreas Madsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Luigi Pinca

async_hooks: don't set hook_fields[kTotals] to 0

2018-03-11T15:33:43+00:00

This commit removes the setting of hook_field[kTotals] to szero in
AsyncHook's enable function.

As far as I can tell this would not be required if the setting of
this field is done with the assignment operator instead of using the
addition assignment operator.

PR-URL: https://github.com/nodejs/node/pull/19219
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

lib: port errors to new system

2018-03-05T18:51:30+00:00

This is a first batch of updates that touches non-underscored modules in
lib.

PR-URL: https://github.com/nodejs/node/pull/19034
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung