delta/node-new.git/lib/assert.js, branch pull-request-doc-updates

assert: remove unused catch bindings

2018-11-06T15:58:42+00:00

PR-URL: https://github.com/nodejs/node/pull/24079
Reviewed-By: Sam Roberts 
Reviewed-By: Wyatt Preul

assert: remove internal errorCache property

2018-10-09T13:39:46+00:00

The internal assert module exposed an errorCache property solely for
testing. It is no longer necessary. Remove it.

PR-URL: https://github.com/nodejs/node/pull/23304
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani

assert: add default operator to `assert.fail()`

2018-09-17T13:59:12+00:00

This makes sure `assert.fail()` contains an operator instead of being
undefined.

On top of that it also fixes the `err.generatedMessage` property.
Before, it was not always set correct.

PR-URL: https://github.com/nodejs/node/pull/22694
Reviewed-By: John-David Dalton 
Reviewed-By: Matteo Collina

assert: align argument names

2018-09-11T21:45:07+00:00

This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: https://github.com/nodejs/node/pull/22760
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Yuta Hiroto

assert: improve simple assert

2018-07-16T09:30:55+00:00

1) If simple assert is called in the very first line of a file and
it causes an error, it used to report the wrong code. The reason
is that the column that is reported is faulty. This is fixed by
subtracting the offset from now on in such cases.

2) The actual code read is now limited to the part that is actually
required to visualize the call site. All other code in e.g. minified
files will not cause a significant overhead anymore.

3) The number of allocations is now significantly lower than it used
to be. The buffer is reused until the correct line in the code is
found. In general the algorithm tries to safe operations where
possible.

4) The indentation is now corrected depending on where the statement
actually beginns.

5) It is now possible to handle `.call()` and `.apply()` properly.

6) The user defined function name will now always be used instead of
only choosing either `assert.ok()` or `assert()`.

PR-URL: https://github.com/nodejs/node/pull/21626
Reviewed-By: Matteo Collina 
Reviewed-By: Ben Coe 
Reviewed-By: James M Snell

assert: handle undefined filename in getErrMessage

2018-05-23T15:40:10+00:00

When generating an assertion error message,
`filename` might be undefined,
e.g. if `assert` is called in `eval`.

Handle this case gracefully instead of failing with
`Cannot read property 'endsWith' of undefined`.

Fixes: https://github.com/nodejs/node/issues/20847

PR-URL: https://github.com/nodejs/node/pull/20848
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Khaidi Chu 
Reviewed-By: James M Snell

assert: fix wrong message indentation

2018-05-21T15:56:56+00:00

If code is read from a file and that code is indented, it would be
misaligned. This makes sure it has a natural indentation that is
relative to the starting point of the assertion.

PR-URL: https://github.com/nodejs/node/pull/20791
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Khaidi Chu 
Reviewed-By: Matteo Collina

assert: fix EOL issue in messages on Windows

2018-05-18T14:09:00+00:00

PR-URL: https://github.com/nodejs/node/pull/20754
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

assert,util: lazy load comparison functions

2018-05-18T13:27:29+00:00

PR-URL: https://github.com/nodejs/node/pull/20567
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel

os: lazy loaded

2018-05-18T13:25:41+00:00

PR-URL: https://github.com/nodejs/node/pull/20567
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel