delta/node-new.git/lib/_stream_writable.js, branch try_Python3_on_macOS

stream: do not emit drain if stream ended

2019-08-20T15:55:36+00:00

PR-URL: https://github.com/nodejs/node/pull/29086
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

stream: disallow stream methods on finished stream

2019-08-20T15:47:19+00:00

Invoke callback with ERR_STREAM_ALREADY_FINISHED error if `end()` is
called on a finished stream.

PR-URL: https://github.com/nodejs/node/pull/28687
Refs: https://github.com/nodejs/node/issues/28667
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

stream: do not emit after 'error'

2019-08-18T23:27:05+00:00

Do not emit 'prefinish' or 'finish' event after an error.

PR-URL: https://github.com/nodejs/node/pull/28708
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

http,stream: add writableEnded

2019-08-17T07:28:06+00:00

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: https://github.com/nodejs/node/pull/28934
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott

stream: fix destroy() behavior

2019-08-17T04:33:53+00:00

Ensure errorEmitted is always set. Only emit 'error' once.

PR-URL: https://github.com/nodejs/node/pull/29058
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Rich Trott

stream: inline and simplify onwritedrain

2019-08-09T23:42:14+00:00

Inline and simplify onwritedrain. Also remove comment that seems to be
outdated/invalid.

PR-URL: https://github.com/nodejs/node/pull/29037
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

stream: resolve perf regression introduced by V8 7.3

2019-07-27T04:58:09+00:00

This commit contains two fixes:
1. use instanceof instead of Object.getPrototypeOf, as checking an
   object prototype with Object.getPrototypeOf is slower
   than an instanceof check.
2. avoid parseInt(undefined, 10) to get NaN as it regressed.

PR-URL: https://github.com/nodejs/node/pull/28842
Fixes: https://github.com/nodejs/node/issues/28586
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anto Aravinth 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

stream: add writableFinished

2019-06-25T21:46:10+00:00

add a new getter to duplex stream to replace the property `this
.writableState.finished` of the object that inherited duplex.

Refs: https://github.com/nodejs/node/issues/445

PR-URL: https://github.com/nodejs/node/pull/28007
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

stream: use readableObjectMode public api for js stream

2019-05-19T21:37:51+00:00

PR-URL: https://github.com/nodejs/node/pull/27655
Refs: https://github.com/nodejs/node/issues/445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yongsheng Zhang

stream: inline onwriteStateUpdate()

2019-04-16T03:35:26+00:00

The function is very simple and is only called from `onwrite()`.

PR-URL: https://github.com/nodejs/node/pull/27203
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Masashi Hirano 
Reviewed-By: Colin Ihrig 
Reviewed-By: Yongsheng Zhang