delta/node-new.git/lib/_stream_wrap.js, branch Ninja.py-StringIO

lib: assign missed deprecation code

2019-03-07T14:48:55+00:00

Refs: https://github.com/nodejs/node/pull/26245

PR-URL: https://github.com/nodejs/node/pull/26492
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig

lib: deprecate _stream_wrap

2019-03-04T18:27:50+00:00

Its unused by node, and doesn't have a reasonable use outside of node.

See: https://github.com/nodejs/node/pull/25153
See: https://github.com/nodejs/node/pull/16158

PR-URL: https://github.com/nodejs/node/pull/26245
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen

src: use consistent names for JSStream

2018-12-28T20:57:46+00:00

Its confusing to call a js class with a handle a "Wrap", usually it's
the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its
derived from Socket, and makes a JS stream look like a Socket, so call
it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated
some time.

PR-URL: https://github.com/nodejs/node/pull/25153
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski

lib: move _stream_wrap into internals

2017-10-19T16:06:27+00:00

This makes a subsequent possible deprecation easier.

PR-URL: https://github.com/nodejs/node/pull/16158
Reviewed-By: Colin Ihrig 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Tobias Nießen

lib: use destructuring for some constants

2017-10-16T21:34:32+00:00

This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: https://github.com/nodejs/node/pull/16063
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gibson Fahnestock

uv: improvements to process.binding('uv')

2017-08-23T17:51:15+00:00

* ensure that UV_... props are constants
* improve error message ... the error message when passing
  in `err >= 0` to `util._errnoException()` was less than
   useful.
* refine uses of process.binding('uv')

PR-URL: https://github.com/nodejs/node/pull/14933
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig

stream: use more explicit statements

2017-06-29T16:03:54+00:00

Using objectMode with stream_wrap has not worked properly
before and would end in an error.
Therefore prohibit the usage of objectMode alltogether.

This also improves the handling performance due to the
cheaper chunk check and by using explicit statements as they
produce better code from the compiler.

PR-URL: https://github.com/nodejs/node/pull/13863
Reviewed-By: Matteo Collina

errors,stream_wrap: use internal/errors.js

2017-06-20T17:11:02+00:00

PR-URL: https://github.com/nodejs/node/pull/13291
Refs: https://github.com/nodejs/node/issues/11273
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson

stream: ensure that instanceof fast-path is hit.

2017-06-09T19:44:11+00:00

With the new Ignition+TurboFan pipeline, the instanceof fast-path can be
missed if the right-hand side needs a TDZ check, i.e. is const declared
on a surrounding scope. This doesn't apply to Node 8 at this point,
where it's at V8 5.8, but it applies as soon as V8 5.9 rolls. There's
work going on in Ignition (and TurboFan) to optimize those TDZ checks
properly, but those changes will land in V8 6.1, so might not end up in
Node 8.

One way to work-around this in Node core for now is to use var instead
of const for those right-hand sides for instanceof for now, especially
Buffer in case of streams. This is not beautiful, but proper ducktape.
Improves readable-bigread.js by ~23% with Node LKGR.

PR-URL: https://github.com/nodejs/node/pull/13403
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Calvin Metcalf

stream: avoid using forEach

2017-03-17T18:09:10+00:00

PR-URL: https://github.com/nodejs/node/pull/11582
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig