delta/node-new.git/lib/_stream_transform.js, branch main

stream: do not use _stream_* anymore

2021-01-05T18:02:04+00:00

Remove all leftover usage of _stream_* and keep all of them as legacy.
We do not deprecate the old modules to avoid disrupition and ease
maintainance.

PR-URL: https://github.com/nodejs/node/pull/36684
Reviewed-By: Robert Nagy 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

stream: move to internal/streams

2020-09-21T08:23:06+00:00

Move all the streams constructors to internal/streams
and avoid a circular dependencies between the modules.

See: https://github.com/nodejs/readable-stream/issues/348

PR-URL: https://github.com/nodejs/node/pull/35239
Reviewed-By: Robert Nagy 
Reviewed-By: Luigi Pinca 
Reviewed-By: Daijiro Wachi

stream: support async for stream impl functions

2020-08-04T00:54:08+00:00

PR-URL: https://github.com/nodejs/node/pull/34416
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Anto Aravinth

stream: try to wait for flush to complete before 'finish'

2020-07-15T19:23:10+00:00

Due to compat reasons Transform streams don't always wait
for flush to complete before finishing the stream.

Try to wait when possible, i.e. when the user does not
override _final.

Fixes: https://github.com/nodejs/node/issues/34274

PR-URL: https://github.com/nodejs/node/pull/34314
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: Zeyu Yang

stream: fix _final and 'prefinish' timing

2020-04-22T07:40:03+00:00

This PR fixes a few different things:

The timing of 'prefinish' depends on whether or not
_final is defined. In on case the event is emitted
synchronously with end() and otherwise asynchronously.

_final is currently unecessarily called asynchronously
which forces implementors to use 'prefinish' as a hack
to emulate synchronous behaviour. Furthermore, this hack
is subtly broken due to the above issue.

Refs: https://github.com/nodejs/node/issues/31401
Refs: https://github.com/nodejs/node/pull/32763#discussion_r407041983

PR-URL: https://github.com/nodejs/node/pull/32780
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

stream: simplify Transform stream implementation

2020-04-15T19:25:42+00:00

Significantly simplified Transform stream implementation by
using mostly standard stream code.

PR-URL: https://github.com/nodejs/node/pull/32763
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

stream: change var to let/const in stream files

2020-03-30T08:25:41+00:00

PR-URL: https://github.com/nodejs/node/pull/32214
Reviewed-By: Robert Nagy 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

http,stream: make virtual methods throw an error

2020-03-07T06:27:02+00:00

Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead
of emitting it.

The error is not recoverable and the only way to handle it is to
override the method.

PR-URL: https://github.com/nodejs/node/pull/31912
Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

lib: flatten access to primordials

2019-11-25T09:28:15+00:00

Store all primordials as properties of the primordials object.
Static functions are prefixed by the constructor's name and prototype
methods are prefixed by the constructor's name followed by "Prototype".
For example: primordials.Object.keys becomes primordials.ObjectKeys.

PR-URL: https://github.com/nodejs/node/pull/30610
Refs: https://github.com/nodejs/node/issues/29766
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

stream: remove TODO and add a description instead

2019-05-02T21:16:14+00:00

After looking into this it turned out that these two errors are
sanity checks that should not be reached. It is unfortunate that
we assigned error codes for these but changing it into an assertion
seems to be a hassle for `readable-streams`.

PR-URL: https://github.com/nodejs/node/pull/27086
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott