delta/node-new.git/lib/_stream_transform.js, branch Ninja.py-StringIO

stream: remove TODO and add a description instead

2019-05-02T21:16:14+00:00

After looking into this it turned out that these two errors are
sanity checks that should not be reached. It is unfortunate that
we assigned error codes for these but changing it into an assertion
seems to be a hassle for `readable-streams`.

PR-URL: https://github.com/nodejs/node/pull/27086
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

benchmark,lib: change var to const

2019-03-30T12:16:39+00:00

Refs: https://github.com/nodejs/node/pull/26679

PR-URL: https://github.com/nodejs/node/pull/26915
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann

stream: make sure 'readable' is emitted before ending the stream

2019-03-06T08:38:29+00:00

Fixes: https://github.com/nodejs/node/issues/25810

PR-URL: https://github.com/nodejs/node/pull/26059
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

lib: use ES6 class inheritance style

2018-12-05T15:55:00+00:00

PR-URL: https://github.com/nodejs/node/pull/24755
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

lib: remove `inherits()` usage

2018-12-05T15:53:58+00:00

This switches all `util.inherits()` calls to use
`Object.setPrototypeOf()` instead. In fact, `util.inherits()` is
mainly a small wrapper around exactly this function while adding
the `_super` property on the object as well.

Refs: #24395

PR-URL: https://github.com/nodejs/node/pull/24755
Refs: https://github.com/nodejs/node/issues/24395
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

stream: make virtual methods errors consistent

2018-03-12T13:24:34+00:00

Use the same error code and always emit the error instead of
throwing it.

PR-URL: https://github.com/nodejs/node/pull/18813
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Michaë Zasso 
Reviewed-By: Matteo Collina

lib: port remaining errors to new system

2018-03-07T13:54:38+00:00

PR-URL: https://github.com/nodejs/node/pull/19137
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung