delta/node-new.git/lib/_stream_duplex.js, branch try_Python3_on_macOS

http,stream: add writableEnded

2019-08-17T07:28:06+00:00

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: https://github.com/nodejs/node/pull/28934
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott

stream: add writableFinished

2019-06-25T21:46:10+00:00

add a new getter to duplex stream to replace the property `this
.writableState.finished` of the object that inherited duplex.

Refs: https://github.com/nodejs/node/issues/445

PR-URL: https://github.com/nodejs/node/pull/28007
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

lib: enforce the use of Object from primordials

2019-04-12T03:38:45+00:00

PR-URL: https://github.com/nodejs/node/pull/27146
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

benchmark,doc,lib: capitalize more comments

2019-03-27T16:20:06+00:00

PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

lib: use ES6 class inheritance style

2018-12-05T15:55:00+00:00

PR-URL: https://github.com/nodejs/node/pull/24755
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

lib: remove `inherits()` usage

2018-12-05T15:53:58+00:00

This switches all `util.inherits()` calls to use
`Object.setPrototypeOf()` instead. In fact, `util.inherits()` is
mainly a small wrapper around exactly this function while adding
the `_super` property on the object as well.

Refs: #24395

PR-URL: https://github.com/nodejs/node/pull/24755
Refs: https://github.com/nodejs/node/issues/24395
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

stream: only check options once in Duplex ctor

2018-04-28T15:13:55+00:00

This commit updates the Duplex constructor adding an if statement
checking if options is undefined, and removes the check from the
following three if statements.

PR-URL: https://github.com/nodejs/node/pull/20353
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca