delta/node-new.git/lib/_http_server.js, branch try_Python3_on_macOS

http: reset parser.incoming when server request is finished

2019-08-26T13:22:04+00:00

This resolves a memory leak for keep-alive connections and does not
regress in the way that 779a05d5d1bfe2eeb05386f did by waiting for
the incoming request to be finished before releasing the
`parser.incoming` object.

Refs: https://github.com/nodejs/node/pull/28646
Refs: https://github.com/nodejs/node/pull/29263
Fixes: https://github.com/nodejs/node/issues/9668

PR-URL: https://github.com/nodejs/node/pull/29297
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

Revert "http: reset parser.incoming when server response is finished"

2019-08-24T16:56:19+00:00

This reverts commit 779a05d5d1bfe2eeb05386f6415d36f80ca0b3b5.

PR-URL: https://github.com/nodejs/node/pull/29263
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

http: simplify drain()

2019-08-19T19:56:08+00:00

Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: https://github.com/nodejs/node/pull/29081
Reviewed-By: Matteo Collina

http: replace superfluous connection property with getter/setter

2019-08-17T13:21:59+00:00

PR-URL: https://github.com/nodejs/node/pull/29015
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

http: follow symbol naming convention

2019-08-14T22:54:01+00:00

PR-URL: https://github.com/nodejs/node/pull/29091
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

http: remove duplicate check

2019-08-11T21:48:12+00:00

`socketOnDrain()` performs the exact same check and doesn't return
anything.

PR-URL: https://github.com/nodejs/node/pull/29022
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

http: reset parser.incoming when server response is finished

2019-07-28T20:14:55+00:00

This resolves a memory leak for keep-alive connections with a naïve
approach.

Fixes: https://github.com/nodejs/node/issues/9668

PR-URL: https://github.com/nodejs/node/pull/28646
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott

perf_hooks: add HttpRequest statistics monitoring #28445

2019-07-11T22:36:27+00:00

```js
const { PerformanceObserver, performance } = require('perf_hooks');
const http = require('http');

const obs = new PerformanceObserver((items) => {
  const entry = items.getEntries()[0];
  console.log(entry.name, entry.duration);
});
obs.observe({ entryTypes: ['http'] });

const server = http.Server(function(req, res) {
  server.close();
  res.writeHead(200);
  res.end('hello world\n');
});

server.listen(0, function() {
  const req = http.request({
    port: this.address().port,
    path: '/',
    method: 'POST'
  }).end();
});
```

PR-URL: https://github.com/nodejs/node/pull/28486
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater

http: improve parser error messages

2019-07-06T05:36:53+00:00

Include the library-provided reason in the Error’s `message`.

Fixes: https://github.com/nodejs/node/issues/28468

PR-URL: https://github.com/nodejs/node/pull/28487
Reviewed-By: Anto Aravinth 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Fedor Indutny 
Reviewed-By: Rich Trott 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

http: remove default 'timeout' listener on upgrade

2019-06-08T11:35:37+00:00

Remove the default listener of the `'timeout'` event from the socket
before emitting the `'connect'` or `'upgrade'` event.

PR-URL: https://github.com/nodejs/node/pull/26030
Fixes: https://github.com/nodejs/node/issues/23857
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott