delta/node-new.git/lib/_http_outgoing.js, branch try_Python3_on_macOS

stream: disallow stream methods on finished stream

2019-08-20T15:47:19+00:00

Invoke callback with ERR_STREAM_ALREADY_FINISHED error if `end()` is
called on a finished stream.

PR-URL: https://github.com/nodejs/node/pull/28687
Refs: https://github.com/nodejs/node/issues/28667
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

http: simplify drain()

2019-08-19T19:56:08+00:00

Simplify and slightly optimize draining outgoing http streams. Avoid
extra event listener and inline with rest of the drain logic.

PR-URL: https://github.com/nodejs/node/pull/29081
Reviewed-By: Matteo Collina

http: replace superfluous connection property with getter/setter

2019-08-17T13:21:59+00:00

PR-URL: https://github.com/nodejs/node/pull/29015
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

http,stream: add writableEnded

2019-08-17T07:28:06+00:00

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: https://github.com/nodejs/node/pull/28934
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott

http: follow symbol naming convention

2019-08-14T22:54:01+00:00

PR-URL: https://github.com/nodejs/node/pull/29091
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

http: remove redundant condition

2019-08-12T20:53:17+00:00

`conn.destroyed` is guaranteed to be `false` because a previous `if`
statement already handles the case where `conn && conn.destroyed`
evaluates to `true` returning `false` in that case.

PR-URL: https://github.com/nodejs/node/pull/29078
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott

http: add missing stream-like properties to OutgoingMessage

2019-08-11T01:59:10+00:00

PR-URL: https://github.com/nodejs/node/pull/29018
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

http: buffer writes even while no socket assigned

2019-08-09T22:55:35+00:00

PR-URL: https://github.com/nodejs/node/pull/29019
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

http: add response.writableFinished

2019-07-16T17:26:08+00:00

response.writableFinished is true if all data has been flushed to the
underlying system.

PR-URL: https://github.com/nodejs/node/pull/28681
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

http: call write callback even if there is no message body

2019-06-01T13:18:06+00:00

Ensure that the callback of `OutgoingMessage.prototype.write()` is
called when `outgoingMessage._hasBody` is `false` (HEAD method, 204
status code, etc.).

Refs: https://github.com/nodejs/node/pull/27709

PR-URL: https://github.com/nodejs/node/pull/27777
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott