delta/node-new.git/lib/_http_client.js, branch pull-request-doc-updates

http: make timeout event work with agent timeout

2019-01-31T10:51:25+00:00

The `'timeout'` event is currently not emitted on the `ClientRequest`
instance when the socket timeout expires if only the `timeout` option
of the agent is set. This happens because, under these circumstances,
`listenSocketTimeout()` is not called.

This commit fixes the issue by calling it also when only the agent
`timeout` option is set.

PR-URL: https://github.com/nodejs/node/pull/25488
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

http: make ClientRequest#setTimeout() noop at end

2019-01-22T04:25:47+00:00

Originally discovered and resolved by @szmarczak.

PR-URL: https://github.com/nodejs/node/pull/25536
Fixes: https://github.com/nodejs/node/issues/25499
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

lib: remove internal `util._extends()` usage

2018-12-20T12:52:44+00:00

This removes all internal calls to the deprecated `_extends()`
function. It is slower than `Object.assign()` and the object spread
notation since V8 6.8 and using the spread notation often also
results in shorter code.

PR-URL: https://github.com/nodejs/node/pull/25105
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

http: make parser choice a runtime flag

2018-12-06T04:21:36+00:00

Add a `--http-parser=llhttp` vs `--http-parser=traditional`
command line switch, to make testing and comparing the new
llhttp-based implementation easier.

PR-URL: https://github.com/nodejs/node/pull/24739
Refs: https://github.com/nodejs/node/issues/24730
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Fedor Indutny 
Reviewed-By: Gus Caplan 
Reviewed-By: Matheus Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Ali Ijaz Sheikh

lib: use ES6 class inheritance style

2018-12-05T15:55:00+00:00

PR-URL: https://github.com/nodejs/node/pull/24755
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

lib: remove `inherits()` usage

2018-12-05T15:53:58+00:00

This switches all `util.inherits()` calls to use
`Object.setPrototypeOf()` instead. In fact, `util.inherits()` is
mainly a small wrapper around exactly this function while adding
the `_super` property on the object as well.

Refs: #24395

PR-URL: https://github.com/nodejs/node/pull/24755
Refs: https://github.com/nodejs/node/issues/24395
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina

lib: change anonymous function to arrow function

2018-11-26T12:06:35+00:00

PR-URL: https://github.com/nodejs/node/pull/24589
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Shingo Inoue

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10T06:45:56+00:00

This adds missing async_hooks destroy calls for sockets (in
_http_agent.js) and HTTP parsers. We need to emit a destroy in
AsyncWrap#AsyncReset before assigning a new async_id when the instance
has already been in use and is being recycled, because in that case, we
have already emitted an init for the "old" async_id.

This also removes a duplicated init call for HTTP parser: Each time a
new parser was created, AsyncReset was being called via the C++ Parser
class constructor (super constructor AsyncWrap) and also via
Parser::Reinitialize.

PR-URL: https://github.com/nodejs/node/pull/23272
Fixes: https://github.com/nodejs/node/issues/19859
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

bootstrapper: move internalBinding to NativeModule

2018-10-04T09:55:34+00:00

internalBinding is used so often that it should just automatically be
available for usage in internals.

PR-URL: https://github.com/nodejs/node/pull/23025
Refs: https://github.com/nodejs/node/commit/2a9eb31
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat