delta/node-new.git/lib/_http_agent.js, branch sam-github-tsc

http: add maxTotalSockets to agent class

2020-06-21T16:20:05+00:00

Add maxTotalSockets to determine how many sockets an agent can open.
Unlike maxSockets, The maxTotalSockets does not count by per origin.

PR-URL: https://github.com/nodejs/node/pull/33617
Fixes: https://github.com/nodejs/node/issues/31942
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

lib: improve debuglog() performance

2020-05-30T21:24:43+00:00

PR-URL: https://github.com/nodejs/node/pull/32260
Reviewed-By: James M Snell

http: simplify Agent initialization

2020-05-28T14:18:55+00:00

PR-URL: https://github.com/nodejs/node/pull/33551
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Denys Otrishko 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Robert Nagy

http: added scheduling option to http agent

2020-05-20T09:00:14+00:00

In some cases, it is preferable to use a lifo scheduling strategy
for the free sockets instead of default one, which is fifo.
This commit introduces a scheduling option to add the ability
to choose which strategy best fits your needs.

PR-URL: https://github.com/nodejs/node/pull/33278
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina

http: ensure client request emits close

2020-05-04T09:35:58+00:00

If socket creation failed then an error would be
emitted on the client request object, but not
'close' nor would destroyed be set to true.

PR-URL: https://github.com/nodejs/node/pull/33178
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig

http: set default timeout in agent keepSocketAlive

2020-04-30T20:42:23+00:00

Previous location of setting the timeout would override
behaviour of custom HttpAgents' keepSocketAlive. Moving
it into the default keepSocketAlive allows it to
interoperate with custom agents.

Fixes: https://github.com/nodejs/node/issues/33111

PR-URL: https://github.com/nodejs/node/pull/33127
Reviewed-By: Anna Henningsen 
Reviewed-By: Robert Nagy 
Reviewed-By: Luigi Pinca 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Andrey Pechkurov

http: refactor agent 'free' handler

2020-04-15T00:13:51+00:00

Remove nesting in favor of early returns.

PR-URL: https://github.com/nodejs/node/pull/32801
Reviewed-By: Zeyu Yang 
Reviewed-By: Denys Otrishko 
Reviewed-By: Anna Henningsen

http: move free socket error handling to agent

2020-03-30T08:25:03+00:00

The http client should not know anything about free sockets. Let
the agent handle its pool of sockets.

PR-URL: https://github.com/nodejs/node/pull/32003
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

http, async_hooks: remove unneeded reference to wrapping resource

2020-03-11T16:31:18+00:00

Remove the reference from handle to the unique/wrapping resource
ReusedHandle as there is meanwhile a strong reference for all async
resources in place via AsyncWarp::resource_.

PR-URL: https://github.com/nodejs/node/pull/32054
Refs: https://github.com/nodejs/node/pull/30959
Refs: https://github.com/nodejs/node/pull/30196
Reviewed-By: Anna Henningsen 
Reviewed-By: Michael Dawson 
Reviewed-By: Ruben Bridgewater

http: fix socket re-use races

2020-03-07T19:51:12+00:00

Whether and when a socket is destroyed or not after a timeout is up to
the user. This leaves an edge case where a socket that has emitted
'timeout' might be re-used from the free pool. Even if destroy is called
on the socket, it won't be removed from the freelist until 'close' which
can happen several ticks later.

Sockets are removed from the free list on the 'close' event.
However, there is a delay between calling destroy() and 'close'
being emitted. This means that it possible for a socket that has
been destroyed to be re-used from the free list, causing unexpected
failures.

PR-URL: https://github.com/nodejs/node/pull/32000
Reviewed-By: Matteo Collina 
Reviewed-By: Denys Otrishko 
Reviewed-By: Luigi Pinca