delta/node-new.git/doc, branch self-resolve-doc

docs: CommonJS self-resolve spec correction

2020-05-14T03:37:22+00:00

doc: add note about clientError writable handling

2020-05-12T18:02:49+00:00

PR-URL: https://github.com/nodejs/node/pull/33308
Reviewed-By: Matteo Collina 
Reviewed-By: Ruben Bridgewater

src: update NODE_MODULE_VERSION to 84

2020-05-12T14:12:21+00:00

Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 8.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: https://github.com/nodejs/node/pull/32831
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Jiawen Geng 
Reviewed-By: Colin Ihrig

doc: fix typo in n-api.md

2020-05-12T03:39:05+00:00

This commit fixes what I think is a typo, even though the section in
question does talk about a environment (env).

PR-URL: https://github.com/nodejs/node/pull/33319
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Gabriel Schulhof

http: emit 'error' on aborted server request

2020-05-10T20:11:21+00:00

Server requests aka. IncomingMessage emits 'aborted'
instead of 'error' which causes confusion when
the object is used as a regular stream, i.e. if
functions working on streams are passed a
server request object they might not work properly
unless they take this into account.

Refs: https://github.com/nodejs/web-server-frameworks/issues/41

PR-URL: https://github.com/nodejs/node/pull/33172
Fixes: https://github.com/nodejs/node/issues/28172
Refs: https://github.com/nodejs/node/pull/28677
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen

http: return this from ClientRequest#destroy()

2020-05-09T17:57:28+00:00

This commit updates ClientRequest#destroy() to return `this`
for consistency with other writable streams.

PR-URL: https://github.com/nodejs/node/pull/32789
Reviewed-By: Robert Nagy 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater

http: return this from IncomingMessage#destroy()

2020-05-09T17:57:28+00:00

This commit updates IncomingMessage#destroy() to return `this`
for consistency with other readable streams.

PR-URL: https://github.com/nodejs/node/pull/32789
Fixes: https://github.com/nodejs/node/issues/32772
Reviewed-By: Robert Nagy 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater

fs: add .ref() and .unref() methods to watcher classes

2020-05-09T05:59:08+00:00

PR-URL: https://github.com/nodejs/node/pull/33134
Fixes: https://github.com/nodejs/node/issues/33096
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

http: expose http.validate-header-name/value

2020-05-09T05:55:55+00:00

The use-case is for any framework that provides user mw a response
replacement, that collects the desired response state, and applies them
only on conclusion. As such a framework, I'd want to validate the
header names and values as soon as the user-code provides them.
This - to eliminate errors on response-send time, and provide developer
stack trace that contains the line that submits the offending values.

PR-URL: https://github.com/nodejs/node/pull/33119
Reviewed-By: Anna Henningsen

async_hooks: move PromiseHook handler to JS

2020-05-09T05:52:22+00:00

This avoids the need to wrap every promise in an AsyncWrap and also
makes it easier to skip the machinery to track destroy events when
there's no destroy listener.

Co-authored-by: Andrey Pechkurov 

PR-URL: https://github.com/nodejs/node/pull/32891
Reviewed-By: Matteo Collina 
Reviewed-By: Andrey Pechkurov 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Chengzhong Wu