delta/node-new.git/benchmark, branch crypto_set_integer_macro

benchmark: add common.binding()

2018-10-14T17:23:16+00:00

Recently, process.binding() was replaced with internalBinding().
However, internalBinding() is not available on older builds of
Node, which are often used for benchmarking purposes. This commit
adds a common.binding() to the benchmarks to work around the
issue. Hopefully, this can be removed in the not too distant
future.

PR-URL: https://github.com/nodejs/node/pull/23460
Fixes: https://github.com/nodejs/node/issues/23436
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Weijia Wang 
Reviewed-By: Trivikram Kamat

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10T06:45:56+00:00

This adds missing async_hooks destroy calls for sockets (in
_http_agent.js) and HTTP parsers. We need to emit a destroy in
AsyncWrap#AsyncReset before assigning a new async_id when the instance
has already been in use and is being recycled, because in that case, we
have already emitted an init for the "old" async_id.

This also removes a duplicated init call for HTTP parser: Each time a
new parser was created, AsyncReset was being called via the C++ Parser
class constructor (super constructor AsyncWrap) and also via
Parser::Reinitialize.

PR-URL: https://github.com/nodejs/node/pull/23272
Fixes: https://github.com/nodejs/node/issues/19859
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

benchmark: increase lint compliance

2018-10-07T23:58:45+00:00

Remove two eslint-disable comments by replacing string concatenation
with template literals. These changes are in catch blocks that are not
part of the actual code being benchmarked.

PR-URL: https://github.com/nodejs/node/pull/23305
Reviewed-By: Anna Henningsen 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

benchmark: refactor util benchmarks

2018-09-07T17:58:36+00:00

This significantly reduces the benchmark runtime. It removes to many
variations that do not provide any benefit and reduces the iterations.

PR-URL: https://github.com/nodejs/node/pull/22503
Reviewed-By: Matteo Collina 
Reviewed-By: John-David Dalton 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Refael Ackermann

util: make util binding internal

2018-09-06T01:53:11+00:00

Refs: https://github.com/nodejs/node/issues/22160
PR-URL: https://github.com/nodejs/node/pull/22675
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

benchmark: add lines to scatter plots

2018-09-02T11:15:41+00:00

Adds lines between the points of the same category in scatter.R plots.

PR-URL: https://github.com/nodejs/node/pull/22074
Reviewed-By: Andreas Madsen 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu

src: use String::Utf8Length with isolate

2018-08-29T10:28:19+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use String::Write{OneByte,Utf8} with isolate

2018-08-29T10:28:14+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

stream: move process.binding('stream_wrap') to internalBinding

2018-08-19T19:46:10+00:00

PR-URL: https://github.com/nodejs/node/pull/22345
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Matteo Collina 
Reviewed-By: Jon Moss 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater